Skip to content

Fix GHAs (convert-proto, cleanup-release)#403

Merged
karenyrx merged 1 commit intoopensearch-project:mainfrom
karenyrx:tk
Feb 26, 2026
Merged

Fix GHAs (convert-proto, cleanup-release)#403
karenyrx merged 1 commit intoopensearch-project:mainfrom
karenyrx:tk

Conversation

@karenyrx
Copy link
Collaborator

@karenyrx karenyrx commented Feb 26, 2026

Address the following 2 problems:

Problem 1

  • Problem: The convert-proto GHA should not create a new PR in this repository everytime someone makes a PR to this repo, since these autogenerated PRs will never be merged and are a temporary artifact.

  • Fix: A better way is to generate the artifact and expose it in the GHA. Thus modify the GHA to do so.

  • Test Plan: Tested that this GHA run has this step:

Screenshot 2026-02-25 at 8 21 04 PM shows:

Artifact download URL: https://github.com/opensearch-project/opensearch-protobufs/actions/runs/22427514436/artifacts/5666184494

which after downloading looks like this:
Screenshot 2026-02-25 at 8 21 44 PM

Problem 2

  • Problem:cleanup-release GHA recently started failing because a GHA we were depending on has been deleted (Error: Unable to resolve action nguyenvukhang/semver-increment, repository not found, as witnessed in this workflow run).
  • Fix: Remove that dependency and write a simple bash script to increment the minor version ourselves.
  • Test Plan: Tested the bash script locally will increment the version.properties from 1.3.0 to 1.4.0. Plan to run the manually trigger the GHA after this PR is merged to main.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.86%. Comparing base (9fd701d) to head (dfecae5).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files          15       15           
  Lines        1364     1364           
  Branches      369      377    +8     
=======================================
  Hits         1253     1253           
+ Misses        110      105    -5     
- Partials        1        6    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Karen X <karenxyr@gmail.com>
- CombinedFieldsQuery
- DistanceFeatureQuery
- GeoPolygonQuery
- GeoShapeQuery
Copy link
Collaborator Author

@karenyrx karenyrx Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this change before merging - this is for testing only

@karenyrx karenyrx changed the title test Fix GHAs Feb 26, 2026
@karenyrx karenyrx changed the title Fix GHAs Fix GHAs (convert-proto, cleanup-release) Feb 26, 2026
@karenyrx karenyrx marked this pull request as ready for review February 26, 2026 04:24
@karenyrx karenyrx merged commit 64b9e0a into opensearch-project:main Feb 26, 2026
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants