Fix simplifySingleMapSchema to generate named wrapper schemas#406
Merged
lucy66hw merged 3 commits intoopensearch-project:mainfrom Mar 2, 2026
Merged
Fix simplifySingleMapSchema to generate named wrapper schemas#406lucy66hw merged 3 commits intoopensearch-project:mainfrom
lucy66hw merged 3 commits intoopensearch-project:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 91.86% 95.10% +3.24%
==========================================
Files 15 15
Lines 1364 1389 +25
Branches 369 382 +13
==========================================
+ Hits 1253 1321 +68
+ Misses 110 62 -48
- Partials 1 6 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8ff07a2 to
afebc19
Compare
karenyrx
reviewed
Feb 27, 2026
Signed-off-by: xil <fridalu66@gmail.com>
afebc19 to
2ffa4c7
Compare
Signed-off-by: xil <fridalu66@gmail.com>
afc0e9b to
75d5467
Compare
karenyrx
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rewrote simplifySingleMapSchema to create a { field: string, <type_name>: <value_schema> } wrapper instead of reconstructing/merging additional property definitions
Removed removeArrayOfMapWrapper (and its call sites) — array-of-map unwrapping no longer needed
###Test
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.