Bug fix for: Only require model_id once to save a modelreq #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinay Vinod <[email protected]>
Vinay-Vinod
requested review from
b4sjoo,
dhrubo-os,
greaa-aws,
jngz-es,
rbhavna and
ylwu-amzn
as code owners
Signed-off-by: Vinay Vinod <[email protected]>
Signed-off-by: Vinay Vinod <[email protected]>
Signed-off-by: Vinay Vinod <[email protected]>
Signed-off-by: Vinay Vinod <[email protected]>
Signed-off-by: Vinay Vinod <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
=======================================
Coverage 91.47% 91.47%
=======================================
Files 41 41
Lines 4365 4365
=======================================
Hits 3993 3993
Misses 372 372 ☔ View full report in Codecov by Sentry. |
rawwar
reviewed
Dec 19, 2023
|
|
||
|
|
||
| @pytest.fixture | ||
| def mock_opensearch_client(): |
There was a problem hiding this comment.
We might not want to mock Opensearch client. Tests we are running are integration tests. Hence, mocking might not be useful.
There was a problem hiding this comment.
Seems like I am wrong. In this case, we can just mock the client.
There was a problem hiding this comment.
@Vinay-Vinod Thanks for raising the PR. Could you please make sure if this PR addresses all these:
What solution would you like?
I would like to EITHER 1/ only provide the model_id when I instantiate the SentenceTransformerModel and it gets used in all class methods where applicable, rather than randomly defaulting back to "distilbert-tas-b" OR 2/ use save_as_pt as a static method and never instantiate the class at all. Also it would be nice if I could specify the output location of make_model_config_json.
- only provide the model_id when I instantiate the SentenceTransformerModel and it gets used in all class methods where applicable, rather than randomly defaulting back to "distilbert-tas-b"
- In
save_as_ptmethod, if no other model id is given as function parameter, it will use the model id which was initialized with SentenceTransformerModel class. If still a model is given as a parameter then insave_as_ptmethod we'll use that model id. Please let me know if you have any confusion. - it would be nice if I could specify the output location of make_model_config_json --> Can we take care of this one too? Or are you planning to raise another PR for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I implemented a bug fix in opensearch_py_ml/ml_models/sentencetransformermodel.py to ensure that model_id is only required once for saving a model. Comprehensive tests were added in tests/ml_commons/test_ml_commons_client.py and tests/ml_models/test_sentencetransformermodel_pytest.py to validate the functionality.
Issues Resolved
#323
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.