Skip to content

Conversation

@nathaliellenaa
Copy link
Collaborator

Description

Upgrade version and changelog to 1.4.0

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.37%. Comparing base (529ee34) to head (86f2bce).
⚠️ Report is 71 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   91.53%   92.37%   +0.84%     
==========================================
  Files          42       69      +27     
  Lines        4395     6640    +2245     
==========================================
+ Hits         4023     6134    +2111     
- Misses        372      506     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nathaliellenaa
Copy link
Collaborator Author

Adding onnxscript to requirements-dev.txt fixed these failing tests:

FAILED tests/ml_models/test_sentencetransformermodel_pytest.py::test_save_as_onnx
FAILED tests/ml_models/test_sentencetransformermodel_pytest.py::test_make_model_config_json_for_onnx
FAILED tests/ml_models/test_sentencetransformermodel_pytest.py::test_undefined_model_max_length_in_tokenizer_for_onnx
FAILED tests/ml_models/test_sentencetransformermodel_pytest.py::test_save_as_onnx_with_license

E   ModuleNotFoundError: No module named 'onnxscript'

One test test_integration_model_train_register_full_cycle is still consistently failing due to failed model deployment Failed: Exception occurred during first model registration: Model deployment failed.

Having a hard time to reproduce the same error locally. Tried running the test using 2.11 single node cluster locally and all tests are passing. Tried adding this settings, but it doesn't fix the issue, need to investigate further

plugins.ml_commons.max_model_on_node: 20"

Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
@nathaliellenaa
Copy link
Collaborator Author

Failing model deployment in integ test is due to

Get deploy task: {'model_id': 'cTNkDpoBZlP5h8p-duUX', 'task_type': 'DEPLOY_MODEL', 'function_name': 'TEXT_EMBEDDING', 'state': 'FAILED', 'worker_node': ['InvB-AcfRQmIsmHtQ07SGQ'], 'create_time': 1761178062116, 'last_update_time': 1761178062136, 'error': '{"InvB-AcfRQmIsmHtQ07SGQ":"Disk Circuit Breaker is open, please check your resources!"}', 'is_async': True}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants