Skip to content

Conversation

@wanglam
Copy link

@wanglam wanglam commented Jul 28, 2025

Description

Update account nav button style when nav group home enabled, the new look & feel should like screenshot below:
image
image

Category

Enhancement

Why these changes are required?

The OSD PR refactor the left navigation footer and target to released in opensearch 3.2.0. The account nav button UI should be update according the newest design.

What is the old behavior before changes and new behavior after changes?

Only UI changes, the old behavior like below:
image

Issues Resolved

[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.96%. Comparing base (4e6e71e) to head (a9b9c8f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
public/apps/account/account-nav-button.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2279   +/-   ##
=======================================
  Coverage   71.96%   71.96%           
=======================================
  Files          98       98           
  Lines        2679     2679           
  Branches      417      409    -8     
=======================================
  Hits         1928     1928           
  Misses        637      637           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Lin Wang <[email protected]>
@wanglam wanglam changed the title Use LeftBottomActionButton render anchor Update account nav button style when nav group home enabled Jul 29, 2025
wanglam added 2 commits July 29, 2025 17:42
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
@wanglam wanglam marked this pull request as ready for review July 29, 2025 14:50
RyanL1997
RyanL1997 previously approved these changes Jul 30, 2025
<EuiButtonEmpty
size="xs"
flush="both"
className="accountNavButton"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are removing this className in the the new component, should we also remove its scss file - public/apps/account/account-nav-button.scss? Or do we need to apply the same styling to this new component?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. I think we should remove this scss file if we don't need this className anymore. Let me do some investigation to confirm this.

RyanL1997

This comment was marked as duplicate.

Copy link
Collaborator

@RyanL1997 RyanL1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wanglam, in generally this is looking good to me, and I just left a minor comment.

@wanglam
Copy link
Author

wanglam commented Jul 31, 2025

Hi @RyanL1997, Thanks for reviewing my PR. We have some differing decisions on the left navigation changes. We may need to revert all the left navigation changes today. I will convert this PR to draft and may close this PR.

@wanglam wanglam marked this pull request as draft July 31, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants