fixes

Signed-off-by: Nils Bandener <[email protected]>

Author: nibix

src/main/java/org/opensearch/security/privileges/PrivilegesEvaluatorImpl.java

@@ -414,7 +414,7 @@ public PrivilegesEvaluatorResponse evaluate(PrivilegesEvaluationContext context)
                         if (!replaceResult.continueEvaluation) {
                             if (replaceResult.accessDenied) {
                                 auditLog.logMissingPrivileges(action0, request, task);
-                                return PrivilegesEvaluatorResponse.insufficient(action0);
+                                return presponse;
                             } else {
                                 return PrivilegesEvaluatorResponse.ok().with(replaceResult.createIndexRequestBuilder);
                             }

src/main/java/org/opensearch/security/privileges/SystemIndexAccessEvaluator.java

@@ -280,7 +280,7 @@ private PrivilegesEvaluatorResponse evaluateSystemIndicesAccess(
                         .collect(Collectors.toList());
                     log.debug("Service account cannot access regular indices: {}", regularIndices);
                 }
-                return PrivilegesEvaluatorResponse.insufficient(action).reason("Service account cannot access regular indices");
+                return PrivilegesEvaluatorResponse.insufficient("").reason("Service account cannot access regular indices");
             }
             boolean containsProtectedIndex = requestContainsAnyProtectedSystemIndices(requestedResolved);
             if (containsProtectedIndex) {
@@ -332,7 +332,7 @@ private PrivilegesEvaluatorResponse evaluateSystemIndicesAccess(
                                 matchingPluginIndices
                             );
                         }
-                        return PrivilegesEvaluatorResponse.insufficient(action);
+                        return PrivilegesEvaluatorResponse.insufficient("");
                     }
                 }
             } else {
@@ -357,7 +357,7 @@ private PrivilegesEvaluatorResponse evaluateSystemIndicesAccess(
                 } else {
                     auditLog.logSecurityIndexAttempt(request, action, task);
                     log.warn("{} for '_all' indices is not allowed for a regular user", action);
-                    return PrivilegesEvaluatorResponse.insufficient(action);
+                    return PrivilegesEvaluatorResponse.insufficient("");
                 }
             }
             // if system index is enabled and system index permissions are enabled we don't need to perform any further
@@ -370,7 +370,7 @@ else if (containsSystemIndex && !isSystemIndexPermissionEnabled) {
                         if (log.isDebugEnabled()) {
                             log.debug("Filtered '{}' but resulting list is empty", securityIndex);
                         }
-                        return PrivilegesEvaluatorResponse.insufficient(action);
+                        return PrivilegesEvaluatorResponse.insufficient("");
                     }
                     irr.replace(request, false, allWithoutSecurity.toArray(new String[0]));
                     if (log.isDebugEnabled()) {
@@ -380,7 +380,7 @@ else if (containsSystemIndex && !isSystemIndexPermissionEnabled) {
                     auditLog.logSecurityIndexAttempt(request, action, task);
                     final String foundSystemIndexes = String.join(", ", getAllSystemIndices(requestedResolved));
                     log.warn("{} for '{}' index is not allowed for a regular user", action, foundSystemIndexes);
-                    return PrivilegesEvaluatorResponse.insufficient(action);
+                    return PrivilegesEvaluatorResponse.insufficient("");
                 }
             }
         }