Support line comment and block comment in PPL#2806
Merged
LantaoJin merged 2 commits intoopensearch-project:mainfrom Apr 8, 2025
Merged
Support line comment and block comment in PPL#2806LantaoJin merged 2 commits intoopensearch-project:mainfrom
LantaoJin merged 2 commits intoopensearch-project:mainfrom
Conversation
ec99e57 to
9b0074e
Compare
dai-chen
previously approved these changes
Jul 10, 2024
Collaborator
dai-chen
left a comment
There was a problem hiding this comment.
Thanks for the changes!
Member
Author
Contributor
|
This PR is stalled because it has been open for 30 days with no activity. |
YANG-DB
previously approved these changes
Dec 30, 2024
Contributor
|
This PR is stalled because it has been open for 30 days with no activity. |
Member
|
hi @LantaoJin |
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
bab9b16 to
16cf155
Compare
qianheng-aws
approved these changes
Apr 7, 2025
Member
Author
dai-chen
approved these changes
Apr 7, 2025
Collaborator
dai-chen
left a comment
There was a problem hiding this comment.
I saw our SQL support line comment by # or --. This PPL line comment syntax is trying to consistent with SPL?
Member
Author
Yes. |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2806-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e0b72683a1ad4758276be802bfaf2c8de0e01d7d
# Push it to GitHub
git push --set-upstream origin backport/backport-2806-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.xThen, create a pull request where the |
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Support line comment and block comment in PPL Signed-off-by: Lantao Jin <ltjin@amazon.com> * add user doc Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding both block comment
/* ... */and line comment//support for PPL.For example:
Issues Resolved
Resolves #2805
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.