[v3.0.0] Deprecate scroll API usage#3346
Conversation
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
is there any todo item? |
noCharger
left a comment
There was a problem hiding this comment.
Nit: Rebase and merge conflict
This branch has conflicts that must be resolved
Signed-off-by: Tomoyuki MORITA <moritato@amazon.com>
No, I mean fixed tests in this PR. |
Fixed. |
dai-chen
left a comment
There was a problem hiding this comment.
Thanks for the changes! Could you double check no impact on JDBC/ODBC driver? I recall they depend on this feature.
Thanks, looks it depends on https://github.com/opensearch-project/sql-odbc/blob/578196bb16a96899cc8964886de77d751a5a3ec7/src/sqlodbc/odbcapi30.c#L152 |
|
Tested JDBC/ODBC driver to work with this change (PIT). |
Description
Related Issues
Resolves #3284
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.