Execute Calcite PPL query in thread pool#3508
Merged
LantaoJin merged 1 commit intoopensearch-project:mainfrom Apr 2, 2025
Merged
Execute Calcite PPL query in thread pool#3508LantaoJin merged 1 commit intoopensearch-project:mainfrom
LantaoJin merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Lantao Jin <ltjin@amazon.com>
dai-chen
approved these changes
Apr 1, 2025
Collaborator
dai-chen
left a comment
There was a problem hiding this comment.
Just wonder calcite planner is also required to run in worker thread?
Collaborator
|
Please double check the CI failure. Thanks! |
penghuo
approved these changes
Apr 1, 2025
Member
Author
Calcite planner is generated per query. So it should be safe in thread pool. PS: I found this change is useless. Below code should be equivalent after #792 @dai-chen Merge this PR to keep code style consistent. |
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Execute Calcite PPL query in thread pool
Related Issues
Resolves #3507
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.