Support describe command with Calcite#3624
Merged
LantaoJin merged 3 commits intoopensearch-project:mainfrom May 21, 2025
Merged
Support describe command with Calcite#3624LantaoJin merged 3 commits intoopensearch-project:mainfrom
describe command with Calcite#3624LantaoJin merged 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
dai-chen
reviewed
May 19, 2025
.../src/main/java/org/opensearch/sql/opensearch/storage/system/OpenSearchSystemIndexSchema.java
Show resolved
Hide resolved
...main/java/org/opensearch/sql/opensearch/storage/system/CalciteEnumerableSystemIndexScan.java
Outdated
Show resolved
Hide resolved
...main/java/org/opensearch/sql/opensearch/storage/system/CalciteEnumerableSystemIndexScan.java
Show resolved
Hide resolved
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Member
Author
|
An additional code refactoring introduced with this feature includes:
|
penghuo
approved these changes
May 20, 2025
Comment on lines
+42
to
+56
| @Override | ||
| public @Nullable Pair<RelTraitSet, List<RelTraitSet>> passThroughTraits(RelTraitSet required) { | ||
| return EnumerableRel.super.passThroughTraits(required); | ||
| } | ||
|
|
||
| @Override | ||
| public @Nullable Pair<RelTraitSet, List<RelTraitSet>> deriveTraits( | ||
| RelTraitSet childTraits, int childId) { | ||
| return EnumerableRel.super.deriveTraits(childTraits, childId); | ||
| } | ||
|
|
||
| @Override | ||
| public DeriveMode getDeriveMode() { | ||
| return EnumerableRel.super.getDeriveMode(); | ||
| } |
Member
Author
There was a problem hiding this comment.
Seems tacitly add by IDE. Will delete them in later PR.
dai-chen
approved these changes
May 20, 2025
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Support describe command with Calcite Signed-off-by: Lantao Jin <ltjin@amazon.com> * add java doc and class rename Signed-off-by: Lantao Jin <ltjin@amazon.com> * refactor to remove the useless Queryable interface Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support
describecommand with CalciteRelated Issues
Resolves #3460
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.