Support aggregation/window commands with dynamic fields #4743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykmr1224
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
RyanL1997,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az,
vamsimanohar and
yuancu
as code owners
penghuo
reviewed
Nov 6, 2025
...t/src/test/java/org/opensearch/sql/calcite/standalone/CalciteDynamicFieldsAggregationIT.java
Show resolved
Hide resolved
...t/src/test/java/org/opensearch/sql/calcite/standalone/CalciteDynamicFieldsAggregationIT.java
Outdated
Show resolved
Hide resolved
...t/src/test/java/org/opensearch/sql/calcite/standalone/CalciteDynamicFieldsAggregationIT.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/opensearch/sql/common/utils/DebugUtils.java
Outdated
Show resolved
Hide resolved
...est/src/test/java/org/opensearch/sql/calcite/standalone/CalciteDynamicFieldsTimechartIT.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/calcite/CalciteRelNodeVisitor.java
Outdated
Show resolved
Hide resolved
ykmr1224
force-pushed
the
dynamic-aggregation
branch
2 times, most recently
from
33bab3f to
6b2e491
Compare
Collaborator
Author
|
Updated to utilize type coercion. |
penghuo
reviewed
Nov 7, 2025
Comment on lines
2099
to
2103
| if (!context.fieldBuilder.isFieldSpecificType(byFieldName)) { | ||
| throw new IllegalArgumentException( | ||
| String.format( | ||
| "By field `%s` needs to be specific type. Please cast explicitly.", byFieldName)); | ||
| } |
Collaborator
There was a problem hiding this comment.
Can we cast to string for groupBy field?
Collaborator
Author
There was a problem hiding this comment.
I realized timechart requires bigger change due to type assigned to span function, which prevents automatic type coercion work properly.
Let me address this in a separate PR.
Collaborator
Author
There was a problem hiding this comment.
Found simpler way to solve the problem, and included the change in this PR.
ykmr1224
force-pushed
the
dynamic-aggregation
branch
from
44e2d10 to
0e2d036
Compare
penghuo
reviewed
Nov 13, 2025
Comment on lines
101
to
112
| } else if (SqlTypeUtil.isCharacter(fieldType)) { | ||
| // if first argument is string, consider it as timestamp | ||
| ScalarFunctionImpl function = | ||
| (ScalarFunctionImpl) | ||
| ScalarFunctionImpl.create( | ||
| Types.lookupMethod( | ||
| SpanFunction.class, | ||
| "evalTimestamp", | ||
| String.class, | ||
| int.class, | ||
| String.class)); | ||
| return function.getImplementor().implement(translator, call, RexImpTable.NullAs.NULL); |
Collaborator
There was a problem hiding this comment.
Could u explain it more on this, "// if first argument is string, consider it as timestamp"?
Comment on lines
+2052
to
+2054
| projectDynamicFieldAsString(node.getBinExpression(), context); | ||
| projectDynamicFieldAsString(node.getByField(), context); | ||
|
|
Collaborator
There was a problem hiding this comment.
is it required for all visitor?
Collaborator
There was a problem hiding this comment.
could u add a test in CalciteDynamicFieldsTimechartIT to help understand what is correspond logical plan / sql
Collaborator
Author
There was a problem hiding this comment.
Added CalcitePPLDynamicFieldsTest.java for spark SQL. Added explains in IT.
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
force-pushed
the
dynamic-aggregation
branch
from
d6acee2 to
d552010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for feature branch
feature/permissiveDescription
Related Issues
Permissive mode RFC: #4349
Dynamic fields RFC: #4433
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.