Skip to content

Conversation

@tjungblu
Copy link

You can now channel THE Clayton Coleman (aka smarterclayton) to implement and design features for you.

For example:

/smarterclayton I need to write a downstream openshift feature that will set the event-ttl on the apiserver to a customizable value, how do I do it?

Having built this already myself, you can get reassurance it is exactly like he would do it:

This feature already exists. You don't need to write it - it's been implemented following exactly the patterns I would recommend:
  1. API already defined: /home/tjungblu/git/api/operator/v1/types_kubeapiserver.go:39-52
    - EventTTLMinutes int32 field on KubeAPIServerSpec
    - Validation bounds: 5-180 minutes (sensible operational range)
    - Feature-gated with EventTTL feature gate
    - Default: 3h (180 minutes) when omitted
  2. Observer already implemented: /home/tjungblu/git/cluster-kube-apiserver-operator/pkg/operator/configobservation/apiserver/observe_event_ttl.go
    - Converts EventTTLMinutes → --event-ttl apiserver flag
    - Format conversion: 180 → "180m" duration string
    - Default behavior: 0 or unset → "3h"
    - Change detection and eventing

Bonus points, you can ask Clayton to implement the feature and have it review by /deads (requires #26) afterwards.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.

You can now channel THE Clayton Coleman (aka smarterclayton) to
implement and design features for you.

For example:
> /smarterclayton I need to write a downstream openshift feature that will set the event-ttl on the apiserver to a customizable value, how do I do it?

Having built this already myself, you can get reassurance it is exactly
like he would do it:

```
This feature already exists. You don't need to write it - it's been implemented following exactly the patterns I would recommend:
  1. API already defined: /home/tjungblu/git/api/operator/v1/types_kubeapiserver.go:39-52
    - EventTTLMinutes int32 field on KubeAPIServerSpec
    - Validation bounds: 5-180 minutes (sensible operational range)
    - Feature-gated with EventTTL feature gate
    - Default: 3h (180 minutes) when omitted
  2. Observer already implemented: /home/tjungblu/git/cluster-kube-apiserver-operator/pkg/operator/configobservation/apiserver/observe_event_ttl.go
    - Converts EventTTLMinutes → --event-ttl apiserver flag
    - Format conversion: 180 → "180m" duration string
    - Default behavior: 0 or unset → "3h"
    - Change detection and eventing
```

Bonus points, you can ask Clayton to implement the feature and have it
review by /deads (requires openshift-eng#26) afterwards.

Signed-off-by: Thomas Jungblut <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tjungblu
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from dgoodwin and stbenjam October 17, 2025 13:37
@zaneb
Copy link

zaneb commented Oct 20, 2025

I started a discussion on your other PR (and it probably makes sense to continue it there), but suffice to say I think the same concerns apply here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants