-
Couldn't load subscription status.
- Fork 57
Miscellaenous commands related to testing on OpenShift #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gangwgr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
There might be some overlap between this PR and this previous PR - #23 |
7c35c00 to
3d3d03d
Compare
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "name": "openshift-qe", | |||
| "description": "Miscellaenous commands related to testing on OpenShift", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you're in control of this, but this is a uselessly vague description
| "name": "utils", | ||
| "source": "./plugins/utils", | ||
| "description": "A generic utilities plugin serving as a catch-all for various helper commands" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️ seems like not in scope, but this is a vague description
|
|
||
| ## Instructions | ||
|
|
||
| 1. Ask the user for the following information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these directions to an agent or LLM? If it's an agent they seem overly prescriptive, right down to telling it what tools it has to use. Have you compared the results of testing this with repeated scenarios where only this prompt varies? Does a less prescriptive do better or worse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try not to have too many commands that do the same thing: https://github.com/openshift-eng/ai-helpers/blob/main/plugins/openshift/commands/new-e2e-test.md
| 2. Based on the user's input, generate a comprehensive test case using the Workshop MCP Server tool: | ||
|
|
||
| **For YAML/Gherkin/Go formats:** | ||
| - Use the `generate_ocp_test_case` tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if grep/awk/python make for better tooling? Wouldn't it be better to make the tools available, make the descriptions of what the tools can do quite accurate and let the agent decide to use them based on the widely varying input it may see? I worry if you require tool usage, the agent may perform poorly on any given run when it didn't have to.
# Conflicts: # .claude-plugin/marketplace.json
…iptive instructions # Conflicts: # .claude-plugin/marketplace.json
3d3d03d to
b802768
Compare
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Added a dedicated plugin for OpenShift Quality Engineering tasks
/generate-test-case Command
Generate comprehensive OpenShift test cases in multiple formats:
YAML: Structured test definitions for automation frameworks
Gherkin/BDD: Human-readable Given/When/Then format
Go/Ginkgo: Production-ready Go test code using OpenShift's standard framework
Shell Script: Detailed manual testing guides with:
Step-by-step oc CLI commands
Expected outputs for validation
Complete automation scripts
Troubleshooting sections
Supports testing for all major OpenShift components:
kube-apiserver, kube-controller-manager, kube-scheduler
oauth, registry, ingress, etcd
pod, node, network, storage
/execute-test-case Command
Execute OpenShift test cases with real-time progress and detailed reporting:
Step-by-step execution with live progress tracking
Detailed results for each test step (commands, outputs, exit codes)
Pre-flight checks (cluster connectivity, permissions, oc CLI)
Comprehensive reporting (execution time, pass/fail status, failure analysis)
Configurable settings (custom oc path, kubeconfig, timeouts)
Key Features:
Example Scenarios:
Generate and execute pod deployment tests
Test Event TTL configuration in kube-apiserver
Validate OAuth authentication flows
Test ingress controller configurations
Verify etcd cluster operations
Workflow Integration: