-
Couldn't load subscription status.
- Fork 55
NO-JIRA: feat(claude): enhance jira-solve command to keep the codebase up-to-date #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Check some tools before we start working - Keep the codebase up-to-date and always create new fix branch against the upstream main
|
@zhfeng: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhfeng The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - Check if current directory is a valid git repository | ||
| - Ensure working directory is clean or warn user about uncommitted changes | ||
| - Validate upstream remote is properly configured | ||
| - Fetch latest changes from upstream repository: `git fetch upstream` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this assumes there's a remote that's named upstream. That conflicts with
ai-helpers/plugins/jira/commands/solve.md
Line 97 in 2027cfb
| - Always create the PR against the remote origin |
May be the remote to create the PR against should be a new argument $2 that defaults to origin. If you agree, please make sure to add the argument-hints section in the metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think so. It intends to keep the code up-to-date before starting to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what I'm saying is that your change is not mergeable as it is. The assumptions about "upstream" and "origin" here are not always fair, hence my suggestion on arguments with defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I understand and will take a look. Thanks!
|
Closing/reopening to retrigger CI |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
Checklist: