-
Couldn't load subscription status.
- Fork 55
Add Claude plugin to help test operators from art-images-share repository #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f98e1a5 to
5606c56
Compare
|
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about FBC but looks good except for a couple of small things
5606c56 to
ec4420f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sherine-k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @ashwindasr |
c15efd4 to
fa54a87
Compare
| quay.io/redhat-user-workloads/ocp-art-tenant/art-fbc:ocp__4.20__advanced-cluster-management | ||
| ``` | ||
|
|
||
| ### Step 3: Generate CatalogSource Manifest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is my understanding correct that the setup command exercises the same logic implemented by catalog-source and imds commands? if so, can DRY this by making that logic skills that then all three commands leverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know about skills. Love the suggestion!
|
This was resolved, but I commented #63 (comment) |
|
dropped some feedback, this looks great to me otherwise |
|
Closing/reopening to retrigger prow. |
|
/test images |
…es-share mirror repository This plugin helps test operators built in FBC ([File Based Catalog](https://olm.operatorframework.io/docs/reference/file-based-catalogs/) by Konflux with art-images-share repository Uses skills Introduces 3 commands (catalog-source, idms, setup) Author: sherine-k Assisted by: Claude
fa54a87 to
d0d11b9
Compare
|
/test images |
|
@sherine-k: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR introduces a new plugin
fbc-art-imagesand its commands (catalog-source, idms and setup).Which issue(s) this PR fixes:
In the Brew / ErrataTool world, ART periodically released pre-GA builds to pre-release indexes like '
registry.redhat.io/redhat/redhat-operator-index:v4.19-prerelease-aws-efs-csi-driver-operator'.In Konflux, with FBCs, it is now possible to directly consume the operators from
quay.io/redhat-user-workloads/ocp-art-tenant/art-fbc(a public repository): eg.quay.io/redhat-user-workloads/ocp-art-tenant/art-fbc:ocp__4.20_aws-efs-csi-driver-operatorEven though this image is publicly available, it contains references to related images in
registry.redhat.iowhich might not have been pushed yet.These related images can be consumed from mirror
quay.io/redhat-user-workloads/ocp-art-tenant/art-images-shareby setting up an IDMS on the cluster.This plugin helps the user to:
quay.io/redhat-user-workloads/ocp-art-tenant/art-fbcpull-secretSpecial notes for your reviewer:
Checklist: