Skip to content

Conversation

@sherine-k
Copy link

@sherine-k sherine-k commented Oct 27, 2025

What this PR does / why we need it:

This PR introduces a new plugin fbc-art-images and its commands (catalog-source, idms and setup).

Which issue(s) this PR fixes:

In the Brew / ErrataTool world, ART periodically released pre-GA builds to pre-release indexes like 'registry.redhat.io/redhat/redhat-operator-index:v4.19-prerelease-aws-efs-csi-driver-operator'.
In Konflux, with FBCs, it is now possible to directly consume the operators from quay.io/redhat-user-workloads/ocp-art-tenant/art-fbc (a public repository): eg. quay.io/redhat-user-workloads/ocp-art-tenant/art-fbc:ocp__4.20_aws-efs-csi-driver-operator

Even though this image is publicly available, it contains references to related images in registry.redhat.io which might not have been pushed yet.
These related images can be consumed from mirror quay.io/redhat-user-workloads/ocp-art-tenant/art-images-share by setting up an IDMS on the cluster.

This plugin helps the user to:

  • create a CatalogSource for consuming the operator from the public repository quay.io/redhat-user-workloads/ocp-art-tenant/art-fbc
  • discover all related images for that operator
  • create an IDMS file for setting up mirrors for all images required
  • give instructions to update the cluster's pull-secret

Special notes for your reviewer:

  • From https://docs.google.com/document/d/1YpMZrKUHQG1QAVstVY4Z7RvM3jyZec6sMSCYoNOAaA8/edit?tab=t.0
  • pull-secret.md is merely instructions, instead of a command. This way, credentials to the internal registry art-images-share are not manipulated by the agent.
  • I'm not sure if this qualifies as its own plugin, or if there is a better "home" for these commands.
  • Next step: create IDMS and catalogSource for a list of operators (creating a catalog containing multiple operators)

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2025
@sherine-k
Copy link
Author

/unhold
/assign @stbenjam

@sherine-k sherine-k marked this pull request as ready for review October 27, 2025 15:25
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2025
@openshift-ci openshift-ci bot requested review from dgoodwin and stbenjam October 27, 2025 15:25
Copy link
Member

@stbenjam stbenjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about FBC but looks good except for a couple of small things

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sherine-k
Once this PR has been reviewed and has the lgtm label, please ask for approval from stbenjam. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sherine-k
Copy link
Author

cc @ashwindasr

@sherine-k sherine-k changed the title Add Claude plugins to help test operators from art-images-share repository Add Claude plugin to help test operators from art-images-share repository Oct 27, 2025
@stbenjam stbenjam closed this Oct 27, 2025
@stbenjam stbenjam reopened this Oct 27, 2025
@sherine-k sherine-k force-pushed the fbc-art-images branch 2 times, most recently from c15efd4 to fa54a87 Compare October 28, 2025 08:44
quay.io/redhat-user-workloads/ocp-art-tenant/art-fbc:ocp__4.20__advanced-cluster-management
```

### Step 3: Generate CatalogSource Manifest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is my understanding correct that the setup command exercises the same logic implemented by catalog-source and imds commands? if so, can DRY this by making that logic skills that then all three commands leverage.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about skills. Love the suggestion!

@enxebre
Copy link
Contributor

enxebre commented Oct 28, 2025

This was resolved, but I commented #63 (comment)

@enxebre
Copy link
Contributor

enxebre commented Oct 28, 2025

dropped some feedback, this looks great to me otherwise

@stbenjam stbenjam closed this Oct 28, 2025
@stbenjam stbenjam reopened this Oct 28, 2025
@stbenjam
Copy link
Member

Closing/reopening to retrigger prow.

@stbenjam
Copy link
Member

/test images

…es-share mirror repository

This plugin helps test operators built in FBC ([File Based Catalog](https://olm.operatorframework.io/docs/reference/file-based-catalogs/) by Konflux with art-images-share repository
Uses skills
Introduces 3 commands (catalog-source, idms, setup)
Author: sherine-k
Assisted by: Claude
@sherine-k
Copy link
Author

/test images

@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

@sherine-k: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants