-
Couldn't load subscription status.
- Fork 66
Add OLM Plugin for Day-2 Operator Management #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @chiragkyal. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: chiragkyal <[email protected]>
|
/ok-to-test |
|
To be clear, this works with OLMv0, not v1. IMHO it's fine for it to use the plain plugin path |
@grokspawn Thanks a lot for your valuable feedback, I am aware that this plugin will currently work with OLMv0, and I am planning to extend it as part of a follow-up PR to include v1 as well. How about adding a flag |
Signed-off-by: chiragkyal <[email protected]>
Signed-off-by: chiragkyal <[email protected]>
|
/cc @stbenjam |
|
Is it possible to just have one OLM plugin that does v0 and v1? We've got 3 contending PR's at the moment: |
|
Looks like #54 is compatible and just needs rebasing after this one lands. And if there's anything novel in #76 they can incorporate it into this plugin. This version looks good to me. I'm not super familiar with OLM but the structure looks good, would be good for someone with OLM experience to do the final LGTM /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chiragkyal, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jianzhangbjz @chiragkyal @stbenjam It looks to me like we have some substantial overlap, and not so much duplication here. I think all three are viable, but we probably need to figure out how to reasonably combine them. Because v0 and v1 coexist on the same cluster (with limitations!) it's going to be necessary for folks to explicitly request an interaction with one side or the other. (example limitation: installing the same thing twice for each of v0 + v1 can be bad. v0 first, with v1 later == happy, as v1 will refuse to break a single-owner rule. v1 first, with v0 later == boom, as v0 pretends k8s-native multi-tenancy is real) |
I think some kind of flag will be necessary due to the need to be explicit about which we want to manipulate. We want very much to be in the business of moving people over from v0 sensibilities to v1 ones, so defaulting to 0 isn't my preferred solution. I'm totally onboard with the idea of unifying the plugins to provide a single logical OLM entrypoint. I think my flag preference would be something between what Jian has (bare number) and what you propose (gnu-style, with a v0 default). I'm thinking something like
WDYT? |
Thanks for your feedback. I will try to merge #76 into this common plugin with an explicit selection, in a follow-up PR.
I liked the idea of applying one time selection using something like
Noted, will make sure this suggestion is incorporated in my next round of PR. |
|
IMHO, I think first goals are to merge #54, then to rebase this on top of it to combine the capabilities (though v0/v1 selection by flag for some commands is a less-than-optimal outcome). |
@grokspawn That sounds like the right approach to me. |
|
#54 is in, you'll need to rebase and run |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR introduces a new plugin for managing day-2 operators in OpenShift clusters using Operator Lifecycle Manager (OLM).
Commands
Core Operations:
/olm:search- Search and discover operators across all catalog sources/olm:install- Install operators with auto-channel discovery and manual/automatic approval modes/olm:list- View all installed operators with health status/olm:status- Get detailed operator health, available updates, and troubleshooting information/olm:uninstall- Safely uninstall operators with orphaned CR detection and optional CRD/namespace cleanupUpdate Management:
/olm:upgrade- Update operators to latest version or switch channels/olm:approve- Approve pending InstallPlans for manual approval workflowsAdministration:
/olm:diagnose- Diagnose and fix common OLM issues (orphaned CRDs, stuck namespaces, failed installations)/olm:catalog- Manage catalog sources (list, add, remove, refresh, status)Key Features
Example Workflow
Troubleshooting: