Skip to content

Add sleep after FBC job trigger for layered operators#2695

Open
ashwindasr wants to merge 3 commits intoopenshift-eng:mainfrom
ashwindasr:fbc-build-sleep
Open

Add sleep after FBC job trigger for layered operators#2695
ashwindasr wants to merge 3 commits intoopenshift-eng:mainfrom
ashwindasr:fbc-build-sleep

Conversation

@ashwindasr
Copy link
Copy Markdown
Contributor

@ashwindasr ashwindasr commented Apr 2, 2026

Summary

  • Adds a 10-second sleep after triggering the build-fbc Jenkins job in the non-openshift fallback path (when OCP_TARGET_VERSIONS is not defined)
  • Prevents timestamp collisions when multiple FBC builds start concurrently
  • The OCP_TARGET_VERSIONS loop already has a 10-second sleep between iterations; openshift groups only trigger a single FBC job so no sleep is needed there

Test plan

  • Verify layered operator bundle builds (e.g. OADP/MTA/MTC) trigger FBC jobs without timestamp collisions

Made with Cursor

Adds a 5-second sleep after triggering the build-fbc Jenkins job in the
non-openshift fallback path (when OCP_TARGET_VERSIONS is not defined).
This prevents timestamp collisions when multiple FBC builds start
concurrently. The OCP_TARGET_VERSIONS loop already has a 10-second
sleep between iterations.

Made-with: Cursor
Entire-Checkpoint: b6d9c79b20c5

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adobes1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0fed9005-570b-41ba-8154-61e65b707338

📥 Commits

Reviewing files that changed from the base of the PR and between 57802be and ff57d66.

📒 Files selected for processing (1)
  • pyartcd/pyartcd/pipelines/olm_bundle_konflux.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyartcd/pyartcd/pipelines/olm_bundle_konflux.py

Walkthrough

Added a 10-second asynchronous delay after triggering a single FBC Jenkins build in the non-OCP_TARGET_VERSIONS path of the OLM bundle Konflux pipeline; multi-target loop behavior remains unchanged.

Changes

Cohort / File(s) Summary
OLM Bundle Konflux Control Flow
pyartcd/pyartcd/pipelines/olm_bundle_konflux.py
Inserted await asyncio.sleep(10) immediately after jenkins.start_build_fbc(...) in the else branch when ocp_target_versions is empty/unset, adding a post-trigger delay for the single-target path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Made-with: Cursor
Entire-Checkpoint: eb5fae7b9f55

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Made-with: Cursor
Entire-Checkpoint: bb1e0660c629

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@ashwindasr ashwindasr added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

@ashwindasr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security ff57d66 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant