Skip to content

[4.18] Set canonical_builders_from_upstream to false for all images - 4.18 #8823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vfreex merged 1 commit into from
Jan 30, 2026
Merged

[4.18] Set canonical_builders_from_upstream to false for all images - 4.18 #8823

vfreex merged 1 commit into from
Jan 30, 2026

Conversation

@vfreex
Copy link
Contributor

@vfreex vfreex commented Jan 30, 2026

Ensure all images use canonical_builders_from_upstream: false by relying on the default value in group.yml. This change removes explicit overrides that were setting it to true, ensuring consistent behavior across all images.

Changes:

  • Removed canonical_builders_from_upstream: true from 6 images:

    • ose-etcd
    • ose-ovn-kubernetes
    • ose-installer-etcd-artifacts
    • ovn-kubernetes-microshift
    • ose-network-interface-bond-cni
    • ovn-kubernetes-base

  • Removed redundant canonical_builders_from_upstream: false from non-ci images (openshift-base-rhel9, openshift-base-nodejs.rhel9) to rely on group.yml default

  • Kept explicit canonical_builders_from_upstream: false in ci-* images

@vfreex
Set canonical_builders_from_upstream to false for all images
c1aa75d 
Ensure all images use canonical_builders_from_upstream: false by
relying on the default value in group.yml. This change removes
explicit overrides that were setting it to true, ensuring consistent
behavior across all images.

Changes:
- Removed canonical_builders_from_upstream: true from 6 images:
  * ose-etcd
  * ose-ovn-kubernetes
  * ose-installer-etcd-artifacts
  * ovn-kubernetes-microshift
  * ose-network-interface-bond-cni
  * ovn-kubernetes-base

- Removed redundant canonical_builders_from_upstream: false from
  non-ci images (openshift-base-rhel9, openshift-base-nodejs.rhel9)
  to rely on group.yml default

- Kept explicit canonical_builders_from_upstream: false in ci-* images
@vfreex vfreex changed the title Set canonical_builders_from_upstream to false for all images Set canonical_builders_from_upstream to false for all images - 4.18 Jan 30, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

@vfreex: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/art-konflux-delivery-repo-check c1aa75d link true /test art-konflux-delivery-repo-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vfreex vfreex changed the title Set canonical_builders_from_upstream to false for all images - 4.18 [4.18] Set canonical_builders_from_upstream to false for all images - 4.18 Jan 30, 2026
locriandev
locriandev reviewed Jan 30, 2026
View reviewed changes
Copy link
Contributor

@locriandev locriandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026
@vfreex vfreex added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vfreex vfreex merged commit 8038946 into openshift-eng:openshift-4.18 Jan 30, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@locriandev locriandev locriandev left review comments

Assignees

@locriandev locriandev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vfreex @locriandev