NO-JIRA: Fix documentation inconsistencies with actual code #41
Conversation
- CLAUDE.md: Fix kcli vars filename, remove non-existent kcli/ directory references - helpers/README.md: Add missing code block closure - README-external-host.md: Fix vars sample filename - README-kcli.md: Fix defaults path, ocp_version, ocp_tag, ksushy_port values - proxy-setup/README.md: Clarify proxy_user is auto-detected - install-dev/README.md: Fix method variable docs and task structure - kcli-install/README.md: Fix defaults file link path 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@fonta-rh: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
The task was using `|| true` which hid failures when adding local SSH keys to cluster VMs, causing ProxyJump connections to fail with "Permission denied". Now properly fails with retries and shows results. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
When starting a fencing topology cluster, ensure the BMC simulator is running so STONITH fencing works properly. Supports both dev-scripts (sushy-tools container) and kcli (ksushy systemd service) deployments. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The ssh-add -L command returns exit code 0 even when it outputs "The agent has no identities", causing garbage to be added to authorized_keys. Now filters out error messages and validates the key format before propagating. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
| bmc_password: "admin123" | ||
| bmc_driver: "redfish" | ||
| ksushy_port: 8000 | ||
| ksushy_port: 9000 |
There was a problem hiding this comment.
I don't have a problem with it, but why did we change this?
There was a problem hiding this comment.
This came from a session with a partner, but I don't remember the exact reason, it might have been about consistency. The default is 9000, not 8000,so this was probably was about aligning with other external documentation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fonta-rh, jaypoulz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Fix documentation inconsistencies and remove old kcli dev instructions
Fix SSH key propagation to cluster VMs that was failing silently due to || true, causing ProxyJump connections to fail with "Permission denied"
Start sushy-tools BMC simulator automatically on startup-cluster for fencing topology clusters (supports both dev-scripts and kcli deployments)