only trigger CI if syncCi is set #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-bot
bot
merged commit eeb0f9f
into
openshift-knative:main
1 check passed
cardil
requested changes
Jun 6, 2025
| Branches: Branches{ | ||
| Main: "main", | ||
| ReleaseNext: "release-next", | ||
| SynchCI: "ci/", |
Member
There was a problem hiding this comment.
Oh. I missed this. I need to restore this line, as it breaks daily check PR on kn-event.
Member
There was a problem hiding this comment.
Or maybe better to introduce a skip flag. Configuring an empty value might not be possible, due to processing of the defaults.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rhuss The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the run of the ci optional by removing the default value for synchCi and skip the trigger step if not set.
Also renamed synchCi to syncCi.