Skip to content

Run hack generate tool directly#1117

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-knative:mainfrom
creydr:fix-hack-tool-install
Feb 19, 2025
Merged

Run hack generate tool directly#1117
openshift-merge-bot[bot] merged 1 commit intoopenshift-knative:mainfrom
creydr:fix-hack-tool-install

Conversation

@creydr
Copy link
Collaborator

@creydr creydr commented Feb 19, 2025

Fixing current issues with installing hack tools

Cloning into '/tmp/hack'...
+ cd /tmp/hack
+ go install github.com/openshift-knative/hack/cmd/generate
go: inconsistent vendoring in /tmp/hack:
...

@creydr creydr requested a review from pierDipi February 19, 2025 11:44
@openshift-ci openshift-ci bot requested a review from lberk February 19, 2025 11:44
@creydr
Copy link
Collaborator Author

creydr commented Feb 19, 2025

/cherry-pick release-v1.17
/cherry-pick release-v1.16
/cherry-pick release-v1.15

@openshift-cherrypick-robot

@creydr: once the present PR merges, I will cherry-pick it on top of release-v1.15, release-v1.16, release-v1.17 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-v1.17
/cherry-pick release-v1.16
/cherry-pick release-v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7158984 into openshift-knative:main Feb 19, 2025
2 checks passed
@openshift-cherrypick-robot

@creydr: new pull request created: #1118

Details

In response to this:

/cherry-pick release-v1.17
/cherry-pick release-v1.16
/cherry-pick release-v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@creydr: new pull request created: #1119

Details

In response to this:

/cherry-pick release-v1.17
/cherry-pick release-v1.16
/cherry-pick release-v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@creydr: new pull request created: #1120

Details

In response to this:

/cherry-pick release-v1.17
/cherry-pick release-v1.16
/cherry-pick release-v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants