[release-v1.16] More Integration backports from upstream #1151
Merged
matzew merged 12 commits intoopenshift-knative:release-v1.16from Mar 11, 2025
Merged
[release-v1.16] More Integration backports from upstream #1151matzew merged 12 commits intoopenshift-knative:release-v1.16from
matzew merged 12 commits intoopenshift-knative:release-v1.16from
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matzew
commented
Feb 25, 2025
matzew
commented
Feb 25, 2025
matzew
force-pushed
the
more_backports_ocp.1.16
branch
from
72ed3a0 to
e5029eb
Compare
Member
Author
|
/retest |
Collaborator
|
/retest |
|
/test 417-images |
💄 Adding missing sinks and sources to schema file Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
) * Adding cert-mananger bits Basics for Cert-manager Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding create cert manifest function Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Use the make cert Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Reconcile Certificate manifest and add RBAC Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Add secret filter to controller Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Look up secrets/certs for sink Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Remove old/wrong Certificate manifest and reference Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Fix controller compile Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Formatting Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * change the reconcile of cert manifest, and run it only w/ some form of TLS Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * using filtered informer Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding Rekt test for IntegrationSink TLS support Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * adding a bit of https port for deployment/service of the IntegrationSink Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Mounting secrets and setting quarkus env vars for TLS support Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding flags for different TLS levels resulting in diffeerent quarkus env vars Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Remove bad comment Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Adding label Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Update codegen Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Disable tmp. the cert manager feature Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Fixing header/year Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * More test tweaking Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> * Remove unused and comment out the hooks for now Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> --------- Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Little refactors on IntegrationSink Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Make Certifacte factory more generic Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew
force-pushed
the
more_backports_ocp.1.16
branch
from
200e206 to
a317a0c
Compare
Member
Author
|
Rebased. I had tons of conflicts on I just accepted the changes, and than I was done w/ the rebase |
Member
Author
|
/retest |
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Collaborator
|
/retest kn-eventing-apiserver-receive-adapter-116-on-pull-request |
|
@creydr: The Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
|
/lgtm |
matzew
changed the title
creydr
reviewed
Mar 11, 2025
Comment on lines
+59
to
+62
| //for _, inf := range []injection.InformerInjector{v1certificate.WithInformer} { | ||
| // injection.Default.RegisterInformer(inf) | ||
| //} | ||
|
|
Member
Author
There was a problem hiding this comment.
no... on purpose.
follow up coming
Member
Author
There was a problem hiding this comment.
is really 1-1 cherry pick from the upstream.
See commits and their upstream PRs, for more
matzew
merged commit bba27c1
into
openshift-knative:release-v1.16
32 of 33 checks passed
This was referenced Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catch up for OCP 1.16, from upstream