[release-v1.16] SinkBinding: Set specific conditions for reconciler steps#1154
Conversation
Instead of setting the ready condition during reconciliation steps, set specific conditions since the ready condition is managed and set according to the state of other conditions. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-v1.17 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-v1.15 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
pierDipi
merged commit 03d4992
into
openshift-knative:release-v1.16
pierDipi
deleted the
cp-45905c755ae74ea3899416df87cec201b0a309cf-v1.16
branch
|
@pierDipi: new pull request created: #1161 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pierDipi: new pull request created: #1162 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Instead of setting the ready condition during reconciliation steps, set specific conditions since the ready condition is managed and set according to the state of other conditions.
Cherry-pick of knative@45905c7