Skip to content

[release-v1.16] Fix camel env vars for sinks#1202

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift-knative:release-v1.16from
matzew:fix_camel_env_vars_for_sinks
Mar 21, 2025
Merged

[release-v1.16] Fix camel env vars for sinks#1202
openshift-merge-bot[bot] merged 2 commits intoopenshift-knative:release-v1.16from
matzew:fix_camel_env_vars_for_sinks

Conversation

@matzew
Copy link
Member

@matzew matzew commented Mar 21, 2025

matzew added 2 commits March 21, 2025 09:24
🔨 Fixing the way we render custom camel tags on go structs. Remove the incorrect alue of the tag and update the function that assembles the actual ENV_VARs

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
💄 Camel provided updates to have more readable ENV_VAR names

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@openshift-ci openshift-ci bot requested review from aliok and lberk March 21, 2025 08:34
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member Author

matzew commented Mar 21, 2025

/test kn-eventing-mqttsource-116-on-pull-request

@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.16-417-images
pull-ci-openshift-knative-eventing-release-v1.16-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.16-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-reconciler
Details

In response to this:

/test kn-eventing-mqttsource-116-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member Author

matzew commented Mar 21, 2025

/test kn-eventing-webhook-116-on-pull-request

@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.16-417-images
pull-ci-openshift-knative-eventing-release-v1.16-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.16-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-reconciler
Details

In response to this:

/test kn-eventing-webhook-116-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member Author

matzew commented Mar 21, 2025

/test kn-eventing-websocketsource-116-on-pull-request

@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.16-417-images
pull-ci-openshift-knative-eventing-release-v1.16-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.16-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-reconciler
Details

In response to this:

/test kn-eventing-websocketsource-116-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member Author

matzew commented Mar 21, 2025

/test kn-eventing-mqttsource-116-on-pull-request

@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.16-417-images
pull-ci-openshift-knative-eventing-release-v1.16-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.16-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-reconciler
Details

In response to this:

/test kn-eventing-mqttsource-116-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member Author

matzew commented Mar 21, 2025

/test kn-eventing-websocketsource-116-on-pull-request

@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images
/test 414-test-conformance
/test 414-test-e2e
/test 414-test-encryption-auth-e2e
/test 414-test-reconciler
/test 417-images
/test 417-test-conformance
/test 417-test-e2e
/test 417-test-encryption-auth-e2e
/test 417-test-reconciler
/test 418-images
/test 418-test-conformance
/test 418-test-e2e
/test 418-test-encryption-auth-e2e
/test 418-test-reconciler

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-eventing-release-v1.16-417-images
pull-ci-openshift-knative-eventing-release-v1.16-417-test-conformance
pull-ci-openshift-knative-eventing-release-v1.16-417-test-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-encryption-auth-e2e
pull-ci-openshift-knative-eventing-release-v1.16-417-test-reconciler
Details

In response to this:

/test kn-eventing-websocketsource-116-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD eaff019 and 2 for PR HEAD 3531125 in total

@openshift-merge-bot openshift-merge-bot bot merged commit e11eb4b into openshift-knative:release-v1.16 Mar 21, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants