Skip to content

[release-v1.16] Fix non-containerized build/run with external deps #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matejvasek
Copy link
Collaborator

Fix non-containerized build/run with external deps.
It's necessary to call "go mod tidy" on scaffolded code.

It's necessary to call "go mod tidy" on scaffolded code.

Signed-off-by: Matej Vašek <[email protected]>
@openshift-ci openshift-ci bot requested review from dsimansk and jrangelramos May 28, 2025 13:55
@matejvasek
Copy link
Collaborator Author

/override Code Style / style / Golang / Lint (pull_request)

Copy link

openshift-ci bot commented May 28, 2025

@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • (pull_request)
  • /
  • Code
  • Golang
  • Lint
  • Style
  • style

Only the following failed contexts/checkruns were expected:

  • ci/prow/418-e2e-oncluster-test
  • ci/prow/418-images
  • ci/prow/418-unit
  • ci/prow/419-e2e-oncluster-test
  • ci/prow/419-unit
  • pull-ci-openshift-knative-kn-plugin-func-release-next-418-e2e-oncluster-test
  • pull-ci-openshift-knative-kn-plugin-func-release-next-418-images
  • pull-ci-openshift-knative-kn-plugin-func-release-next-418-unit
  • pull-ci-openshift-knative-kn-plugin-func-release-v1.16-419-e2e-oncluster-test
  • pull-ci-openshift-knative-kn-plugin-func-release-v1.16-419-unit
  • style / Golang / Lint
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override Code Style / style / Golang / Lint (pull_request)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek
Copy link
Collaborator Author

/override "style / Golang / Lint"

Copy link

openshift-ci bot commented May 28, 2025

@matejvasek: Overrode contexts on behalf of matejvasek: style / Golang / Lint

In response to this:

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek matejvasek requested a review from lkingland May 28, 2025 14:11
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-v1.16@40ce764). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/functions/runner.go 76.92% 2 Missing and 1 partial ⚠️
pkg/oci/go_builder.go 70.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-v1.16    #1317   +/-   ##
================================================
  Coverage                 ?   63.54%           
================================================
  Files                    ?      131           
  Lines                    ?    15828           
  Branches                 ?        0           
================================================
  Hits                     ?    10058           
  Misses                   ?     4803           
  Partials                 ?      967           
Flag Coverage Δ
e2e-test 35.30% <43.47%> (?)
e2e-test-runtime-go 25.48% <0.00%> (?)
e2e-test-runtime-node 24.84% <0.00%> (?)
e2e-test-runtime-quarkus 24.93% <0.00%> (?)
e2e-test-runtime-rust 24.42% <0.00%> (?)
e2e-test-runtime-springboot 24.48% <0.00%> (?)
e2e-test-runtime-typescript 24.93% <0.00%> (?)
integration-tests 50.64% <30.43%> (?)
unit-tests 49.79% <73.91%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Jul 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gauron99
Copy link

/cherry-pick release-v1.17

@openshift-cherrypick-robot

@gauron99: once the present PR merges, I will cherry-pick it on top of release-v1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gauron99 gauron99 merged commit 9a23973 into openshift-knative:release-v1.16 Jul 16, 2025
40 of 46 checks passed
@openshift-cherrypick-robot

@gauron99: new pull request created: #1328

In response to this:

/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants