Skip to content

[release-v1.17] Fix non-containerized build/run with external deps #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-v1.17
Choose a base branch
from
Open

[release-v1.17] Fix non-containerized build/run with external deps #1328

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1317

/assign gauron99

@matejvasek
Fix non-containerized build/run /w external deps
1766e6f 
It's necessary to call "go mod tidy" on scaffolded code.

Signed-off-by: Matej Vašek <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 16, 2025
Merged
@openshift-ci openshift-ci bot requested review from dsimansk and jrangelramos July 16, 2025 14:58
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from gauron99. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gauron99
Copy link

/hold

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 19, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/418-e2e-oncluster-test 1766e6f link true /test 418-e2e-oncluster-test
ci/prow/420-e2e-oncluster-test 1766e6f link true /test 420-e2e-oncluster-test
ci/prow/419-e2e-oncluster-test 1766e6f link true /test 419-e2e-oncluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees

@matejvasek matejvasek

@gauron99 gauron99

Labels
do-not-merge/hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @gauron99 @matejvasek