Skip to content

Conversation

@matejvasek
Copy link
Collaborator

picking knative#3185

@matejvasek matejvasek changed the title Better error message for s2i calls [release-v1.17] Better error message for s2i calls Jan 15, 2026
@matejvasek
Copy link
Collaborator Author

PTAL @jrangelramos @lkingland @gauron99
note the failing tests have nothing to do with PR.

@jrangelramos
Copy link

lgtm

@gauron99
Copy link

/lgtm

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1743dbe and 2 for PR HEAD e054227 in total

@matejvasek matejvasek force-pushed the backport-better-err-msg-s2i branch from e054227 to 0f1ff4d Compare January 20, 2026 15:24
@openshift-ci openshift-ci bot removed the lgtm label Jan 20, 2026
@matejvasek
Copy link
Collaborator Author

rebased

@gauron99
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jan 20, 2026
@matejvasek
Copy link
Collaborator Author

/override "Integration Test (ubuntu-latest)"

Fix this issue in another PR.

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

@matejvasek: Overrode contexts on behalf of matejvasek: Integration Test (ubuntu-latest)

Details

In response to this:

/override "Integration Test (ubuntu-latest)"

Fix this issue in another PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0a0c46b and 2 for PR HEAD 0f1ff4d in total

@matejvasek matejvasek force-pushed the backport-better-err-msg-s2i branch from 0f1ff4d to 2baa686 Compare January 20, 2026 18:52
@openshift-ci openshift-ci bot removed the lgtm label Jan 20, 2026
@gauron99
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 20, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Collaborator Author

/override "Integration Test (ubuntu-latest)"

Fix this issue in another PR.

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2026

@matejvasek: Overrode contexts on behalf of matejvasek: Integration Test (ubuntu-latest)

Details

In response to this:

/override "Integration Test (ubuntu-latest)"

Fix this issue in another PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 62c67d2 into release-v1.17 Jan 20, 2026
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants