[release-v1.17] fix: PaC does not refer tekton hub

.github/workflows/test-integration.yaml

@@ -35,6 +35,11 @@ jobs:
         run: ./hack/allocate.sh
       - name: Setup testing images
         run: ./hack/setup-testing-images.sh
+      - name: Install RH pull secrets for KinD cluster
+        env:
+          RH_REG_USR: ${{ secrets.REGISTRY_REDHAT_IO_USERNAME }}
+          RH_REG_PWD: ${{ secrets.REGISTRY_REDHAT_IO_PASSWORD }}
+        run: ./hack/install-pull-secrets.sh
       - name: Install Tekton
         run: ./hack/install-tekton.sh
       - name: Install Pipelines as Code

.github/workflows/test-podman.yaml

@@ -38,6 +38,13 @@ jobs:
         run: ./hack/registry.sh
       - name: Setup testing images
         run: ./hack/setup-testing-images.sh
+      - name: Install RH pull secrets for KinD cluster
+        env:
+          RH_REG_USR: ${{ secrets.REGISTRY_REDHAT_IO_USERNAME }}
+          RH_REG_PWD: ${{ secrets.REGISTRY_REDHAT_IO_PASSWORD }}
+        run: ./hack/install-pull-secrets.sh
+      - name: Install Tekton
+        run: ./hack/install-tekton.sh
       - name: Integration Test Podman
         env:
           FUNC_REPO_REF: ${{ github.event.pull_request.head.repo.full_name }}

hack/install-tekton.sh

@@ -41,6 +41,11 @@ install_tekton() {
   echo "${green}✅ Tekton${reset}"
 }
 
+install_ocp_git_clone_task() {
+  echo "Installing Openshift Pipelines specific task"
+  kubectl apply -f "$(dirname "$(realpath "$0")")/git-clone.yaml"
+}
+
 # Invoke only when run directly
 # Be a library when sourced     
 if [ "$0" = "${BASH_SOURCE[0]}" ]; then
@@ -50,6 +55,7 @@ if [ "$0" = "${BASH_SOURCE[0]}" ]; then
 
   function main() {
     install_tekton
+    install_ocp_git_clone_task
   }
   main "$@"
 fi

pkg/pipelines/tekton/templates.go

@@ -29,24 +29,6 @@ const (
 	taskGitCloneRef = "git-clone"
 
 	// Following part holds a reference to Git Clone Task to be used in Pipeline template,
-	// the usage depends whether we use direct code upload or Git reference for a standard (non PAC) on-cluster build
-	taskGitClonePACTaskRef = `- name: fetch-sources
-      params:
-        - name: url
-          value: $(params.gitRepository)
-        - name: revision
-          value: $(params.gitRevision)
-      taskRef:
-        kind: Task
-        name: git-clone
-      workspaces:
-        - name: output
-          workspace: source-workspace
-        - name: cache
-          workspace: cache-workspace
-        - name: dockerconfig
-          workspace: dockerconfig-workspace`
-
 	taskGitCloneTaskRef = `- name: fetch-sources
       params:
         - name: URL
@@ -114,13 +96,22 @@ type templateData struct {
 // createPipelineTemplatePAC creates a Pipeline template used for PAC on-cluster build
 // it creates the resource in the project directory
 func createPipelineTemplatePAC(f fn.Function, labels map[string]string) error {
+	gct, err := getGitCloneTask()
+	if err != nil {
+		return fmt.Errorf("error getting git clone task: %v", err)
+	}
+	gts, err := getTaskSpec(gct)
+	if err != nil {
+		return err
+	}
 	data := templateData{
 		FunctionName:         f.Name,
 		Annotations:          f.Deploy.Annotations,
 		Labels:               labels,
 		PipelineName:         getPipelineName(f),
 		RunAfterFetchSources: runAfterFetchSourcesRef,
-		GitCloneTaskRef:      taskGitClonePACTaskRef,
+		GitCloneTaskRef:      taskGitCloneTaskRef,
+		GitCloneTaskSpec:     gts,
 	}
 
 	for _, val := range []struct {

pkg/pipelines/tekton/templates_pack.go

@@ -173,9 +173,6 @@ metadata:
     # The branch or tag we are targeting (ie: main, refs/tags/*)
     pipelinesascode.tekton.dev/on-target-branch: "[{{.PipelinesTargetBranch}}]"
 
-    # Fetch the git-clone task from hub
-    pipelinesascode.tekton.dev/task: {{.GitCloneTaskRef}}
-
     # How many runs we want to keep attached to this event
     pipelinesascode.tekton.dev/max-keep-runs: "5"
 

pkg/pipelines/tekton/templates_s2i.go

@@ -180,9 +180,6 @@ metadata:
     # The branch or tag we are targeting (ie: main, refs/tags/*)
     pipelinesascode.tekton.dev/on-target-branch: "[{{.PipelinesTargetBranch}}]"
 
-    # Fetch the git-clone task from hub
-    pipelinesascode.tekton.dev/task: {{.GitCloneTaskRef}}
-
     # Fetch the pipelie definition from the .tekton directory
     pipelinesascode.tekton.dev/pipeline: {{.PipelineYamlURL}}