Skip to content

Conversation

@dsimansk
Copy link
Contributor

Fixes JIRA #

Proposed Changes

  • Reconcile all image refs

This should fix CSV check as well.

/cc @skonto @pierDipi @creydr

@openshift-ci openshift-ci bot requested review from creydr, pierDipi and skonto February 13, 2025 14:41
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Contributor Author

Generated with: make generated-files

@dsimansk
Copy link
Contributor Author

@pierDipi
Copy link
Member

The scheduled runs are broken?

https://github.com/openshift-knative/serverless-operator/actions/runs/13308521979/job/37164966055#step:11:24

@creydr do you know? I thought this would not happen anymore?

@creydr
Copy link
Contributor

creydr commented Feb 13, 2025

The scheduled runs are broken?
https://github.com/openshift-knative/serverless-operator/actions/runs/13308521979/job/37164966055#step:11:24

@creydr do you know? I thought this would not happen anymore?

It seems that we have references in the latest 1.36 FBC to images, which belong to the 1.35 repo. E.g.:
registry.redhat.io/openshift-serverless-1/kn-client-cli-artifacts-rhel8@sha256:409243052873c14752799af71f024dee7547b90ee93f654f37ade74de5db1ef3 (catalog.yaml#L8750) while this sha is only available in the 1.35 quay repo: https://quay.io/repository/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-client-cli-artifacts

As we'll run into this each time we cut a branch and bump the components, I need to think how we can fix this.
For now, we could create 2/3 consecutive PRs, which run make generated-files and make generate-catalog. So we get the latest changes from the CSV to the bundle and then into the catalog :/

@creydr
Copy link
Contributor

creydr commented Feb 13, 2025

@dsimansk can you also run make generate-catalog (this takes a while), so we get the catalog updated (and maybe already the broken reference sorted out)

@creydr
Copy link
Contributor

creydr commented Feb 14, 2025

@dsimansk can you also run make generate-catalog (this takes a while), so we get the catalog updated (and maybe already the broken reference sorted out)

@pierDipi @dsimansk: #3387 should help for now

@dsimansk
Copy link
Contributor Author

Superseded by #3387.
/close

@openshift-ci openshift-ci bot closed this Feb 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@dsimansk: Closed this PR.

Details

In response to this:

Superseded by #3387.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants