Skip to content

Run testselect directly #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
creydr wants to merge 2 commits into from
Closed

Run testselect directly #3388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
899df52
Install testselect directly
creydr Feb 14, 2025
ba9ef39
Use go run
creydr Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions hack/lib/testselect.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,7 @@

function run_testselect {
if [[ -n "${ARTIFACT_DIR:-}" && -n "${CLONEREFS_OPTIONS:-}" ]]; then
local clonedir rootdir hack_tmp_dir

hack_tmp_dir=$(mktemp -d)
git clone --branch main https://github.com/openshift-knative/hack "$hack_tmp_dir"
pushd "$hack_tmp_dir" || return $?
go install github.com/openshift-knative/hack/cmd/testselect
popd || return $?
rm -rf "$hack_tmp_dir"

local clonedir rootdir
clonedir=$(mktemp -d)

# CLONEREFS_OPTIONS var is set in CI
Expand All @@ -22,7 +14,7 @@ function run_testselect {

# The testselect clones a repository. Make sure it's cloned into a temp dir.
pushd "$clonedir" || return $?
"$(go env GOPATH)/bin/testselect" --testsuites="${rootdir}/test/testsuites.yaml" --clonerefs="${ARTIFACT_DIR}/clonerefs.json" --output="${ARTIFACT_DIR}/tests.txt"
go run github.com/openshift-knative/hack/cmd/testselect@latest --testsuites="${rootdir}/test/testsuites.yaml" --clonerefs="${ARTIFACT_DIR}/clonerefs.json" --output="${ARTIFACT_DIR}/tests.txt"
popd || return $?

logger.info 'Tests to be run:'
Expand Down
Loading