-
Notifications
You must be signed in to change notification settings - Fork 145
infra: configure mintmaker to automerge RPM security updates #3395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: configure mintmaker to automerge RPM security updates #3395
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shajmakh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test e2e-aws-ci-tests |
|
/retest |
338e249 to
1ab78c8
Compare
MintMaker's separate Pull Requests for regular and security RPM lockfile updates create merge conflicts when the security PR is merged first. Configure `rpmVulnerabilityAutomerge` to merge security PRs automatically, preventing future race conditions. MintMaker will pick up the new configuration on its next run. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
Whne updating the base image in the dockerfile, likely we also need to update the RPMs. This ensures that the update of both files are aligned and are under the same PR. ref: https://docs.renovatebot.com/configuration-options/#postupgradetasks Signed-off-by: Shereen Haj <shajmakh@redhat.com>
|
/lgtm |
|
/override ci/prow/e2e-aws-ci-tests |
|
@yanirq: yanirq unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ci-tests failures unrelated to this change |
|
@ffromani: Overrode contexts on behalf of ffromani: ci/prow/e2e-aws-ci-tests DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4399f39
into
openshift-kni:master
|
@shajmakh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
MintMaker's separate Pull Requests for regular and security RPM lockfile updates create merge conflicts when the security PR is merged first. Configure
rpmVulnerabilityAutomergeto merge security PRs automatically, preventing future race conditions. MintMaker will pick up the new configuration on its next run.