enable all integration testing on grpc broker.#242
Merged
clyang82 merged 1 commit intoopenshift-online:mainfrom Jan 13, 2025
Merged
enable all integration testing on grpc broker.#242clyang82 merged 1 commit intoopenshift-online:mainfrom
clyang82 merged 1 commit intoopenshift-online:mainfrom
Conversation
Signed-off-by: morvencao <lcao@redhat.com>
Contributor
|
/ok-to-test |
clyang82
approved these changes
Jan 13, 2025
Contributor
clyang82
left a comment
clyang82
left a comment
There was a problem hiding this comment.
LGTM
we may consider to add some metrics for grpc broker in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://issues.redhat.com/browse/ACM-16832
ensure all integration test cases can be run against both MQTT and gRPC broker.