Skip to content

Allow adding/removing manifests #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clyang82 merged 5 commits into from
Feb 11, 2026
Merged

Allow adding/removing manifests #485

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
df44776
remove check for number and immutable
clyang82 Jan 21, 2026
e064dde
add comprehensive tests for manifest bundle validation
clyang82 Feb 10, 2026
5600d36
Add a new case to replace the existing manifest
clyang82 Feb 11, 2026
76bafa7
add tests for duplicate manifest validation
clyang82 Feb 11, 2026
ff34d88
combine ValidateManifestBundleUpdate with ValidateManifestBundle
clyang82 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions pkg/services/validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,39 +102,9 @@ func ValidateManifestBundleUpdate(new, old datatypes.JSONMap) error {
if oldManifestBundleWrapper == nil {
return fmt.Errorf("old manifest bundle is empty")
}
if len(newManifestBundleWrapper.Manifests) != len(oldManifestBundleWrapper.Manifests) {
return fmt.Errorf("new and old manifest have different number of objects")
}
for i := range newManifestBundleWrapper.Manifests {
if err := ValidateObjectUpdate(newManifestBundleWrapper.Manifests[i], oldManifestBundleWrapper.Manifests[i]); err != nil {
return err
}
}

return nil
}

func ValidateObjectUpdate(new, old datatypes.JSONMap) error {
fldPath := field.NewPath("metadata")

newObj := unstructured.Unstructured{Object: new}
oldObj := unstructured.Unstructured{Object: old}

errs := field.ErrorList{}

errs = append(errs, apivalidation.ValidateImmutableField(newObj.GetAPIVersion(), oldObj.GetAPIVersion(), field.NewPath("apiVersion"))...)
errs = append(errs, apivalidation.ValidateImmutableField(newObj.GetKind(), oldObj.GetKind(), field.NewPath("kind"))...)
errs = append(errs, apivalidation.ValidateImmutableField(newObj.GetName(), oldObj.GetName(), fldPath.Child("name"))...)
errs = append(errs, apivalidation.ValidateImmutableField(newObj.GetNamespace(), oldObj.GetNamespace(), fldPath.Child("namespace"))...)
errs = append(errs, validateMetaData(newObj)...)

if len(errs) == 0 {
return nil
}

return fmt.Errorf("%s", errs.ToAggregate().Error())
}

// validatedAPIVersion tests whether the value passed is a valid apiVersion. A
// valid apiVersion contains a version string that matches DNS_LABEL format,
// with an optional group/ prefix, where the group string matches DNS_SUBDOMAIN
Expand Down
Loading
Loading