Conversation
Signed-off-by: Wei Liu <liuweixa@redhat.com>
WalkthroughThis PR updates documentation files to clarify terminology around ManifestWork and resource bundles across two SKILL.md files, and modifies a bash script to prioritize querying maestro-db pods in the maestro namespace when available, with postgres-breakglass as a fallback option. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.claude/skills/trace-manifestwork/scripts/trace.sh (1)
279-282:⚠️ Potential issue | 🟡 MinorError message lists pods in reverse order of actual check sequence.
The error message states it checked for
postgres-breakglassfirst, thenmaestro-db, but the code actually checksmaestro-dbfirst (line 186) then falls back topostgres-breakglass(line 206). Consider reordering for consistency.Suggested fix
echo "ERROR: No database pod found on service cluster" echo "Checked for:" - echo " - postgres-breakglass deployment (ARO-HCP INT)" echo " - maestro-db pod (Service cluster)" + echo " - postgres-breakglass deployment (ARO-HCP INT)"
|
/cc @clyang82 |
| - **ManifestWork**: The formal Kubernetes Custom Resource Definition (CRD) name used by the Open Cluster Management SDK | ||
| - **Resource bundle**: The term used in Maestro's RESTful API endpoints (e.g., `/api/maestro/v1/resource-bundles`) | ||
|
|
||
| When users refer to "resource bundles," they are talking about ManifestWork resources. Both terms describe a collection of Kubernetes manifests packaged together for delivery to target clusters. The database stores these in the `resources` table, while the Kubernetes cluster manages them as ManifestWork/AppliedManifestWork CRs. |
There was a problem hiding this comment.
we do not have ManifestWork CR, right?
There was a problem hiding this comment.
we have, it just exist in memory
No description provided.