Skip to content

Commit 04a2fbd

Browse files
committed
Skip e2e changes the global ConfigMap for now
It has been too buggy lately and we need to fix it in a different way, by launching them explicitly and sequentially from the test runner. Signed-off-by: Chmouel Boudjnah <[email protected]>
1 parent f057ff6 commit 04a2fbd

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

test/gitea_access_control_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,14 @@ import (
1010
"regexp"
1111
"testing"
1212

13+
"gotest.tools/v3/assert"
14+
1315
"github.com/openshift-pipelines/pipelines-as-code/pkg/apis/pipelinesascode/v1alpha1"
1416
"github.com/openshift-pipelines/pipelines-as-code/pkg/params/settings"
1517
"github.com/openshift-pipelines/pipelines-as-code/test/pkg/configmap"
1618
tgitea "github.com/openshift-pipelines/pipelines-as-code/test/pkg/gitea"
1719
"github.com/openshift-pipelines/pipelines-as-code/test/pkg/options"
1820
"github.com/openshift-pipelines/pipelines-as-code/test/pkg/wait"
19-
"gotest.tools/v3/assert"
2021
)
2122

2223
const okToTestComment = "/ok-to-test"
@@ -256,6 +257,8 @@ func TestGiteaACLCommentsAllowing(t *testing.T) {
256257
// the status of CI shows as success. Now non authorized user pushes to PR, the CI will again go to pending
257258
// and require /ok-to-test again from authorized user.
258259
func TestGiteaACLCommentsAllowingRememberOkToTestFalse(t *testing.T) {
260+
t.Skip("Skipping test changing the global config map for now")
261+
259262
ctx := context.Background()
260263
topts := &tgitea.TestOpts{
261264
TargetEvent: options.PullRequestEvent,

test/gitea_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -679,6 +679,7 @@ func TestGiteaParamsOnRepoCR(t *testing.T) {
679679
}
680680

681681
func TestGiteaParamsOnRepoCRWithCustomConsole(t *testing.T) {
682+
t.Skip("Skipping test changing the global config map for now")
682683
ctx := context.Background()
683684
topts := &tgitea.TestOpts{
684685
CheckForStatus: "success",

test/github_scope_token_to_list_of_private_public_repos_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import (
2929
)
3030

3131
func TestGithubPullRequestScopeTokenToListOfRepos(t *testing.T) {
32+
t.Skip("Skipping test changing the global config map for now")
3233
if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
3334
t.Skip("Skipping test since only enabled for nightly")
3435
}
@@ -54,6 +55,7 @@ func TestGithubPullRequestScopeTokenToListOfRepos(t *testing.T) {
5455
}
5556

5657
func TestGithubPullRequestScopeTokenToListOfReposByGlobalConfiguration(t *testing.T) {
58+
t.Skip("Skipping test changing the global config map for now")
5759
if os.Getenv("NIGHTLY_E2E_TEST") != "true" {
5860
t.Skip("Skipping test since only enabled for nightly")
5961
}

0 commit comments

Comments
 (0)