feat: Add support for Artifact Hub

- Introduced Artifact Hub as the default catalog for remote Tasks and
  Pipelines (since tektonhub is deprecated)
- Kept Tekton Hub support available with 'tektonhub://' prefix (but
  scheduled for deprecation)
- Added a new `hub-catalog-type` key to the configuration to specify the
  catalog type (`tektonhub` or `artifacthub`)
- Added warnings in documentation about Tekton Hub future deprecation
- This allows users to configure multiple remote catalogs of different types
- Refactored the hub fetching logic into a common client interface with
  separate implementations for each hub type, improving maintainability
  and extensibility
- There is one known issue with this migration. When pinning to a specific
  version, this may fail in some cases because ArtifactHub expects semver and
  has moved all tasks to it. For example, if the user had yq:0.2, it
  will need to be yq:0.2.0. We can implement a workaround to support
  this migration in a future pull request.

Jira: https://issues.redhat.com/browse/SRVKP-8207

Signed-off-by: Chmouel Boudjnah <[email protected]>

Author: chmouel

config/302-pac-configmap.yaml

@@ -43,23 +43,34 @@ data:
   # i.e: "owner/private-repo1, org/repo2"
   secret-github-app-scope-extra-repos: ""
 
-  # Tekton HUB API urls
-  hub-url: "https://api.hub.tekton.dev/v1"
+  # The default hub url to use, by default it is artifacthub.
+  hub-url: "https://artifacthub.io"
 
-  # Tekton HUB catalog name
-  hub-catalog-name: "tekton"
+  # The default hub catalog type, by default it is artifacthub.
+  # Other supported values: tektonhub
+  hub-catalog-type: "artifacthub"
 
-  # Additional Hub Catalogs is supported, for example:
+  # Pipelines-as-code uses Artifact Hub by default. For backward
+  # compatibility, until https://hub.tekton.dev/ is discontinued the public
+  # Tekton Hub can also be accessed with the `tektonhub://` prefix (e.g.,
+  # `tektonhub://git-clone`).
   #
-  # catalog-1-id: anotherhub
+  # Additional Hub Catalogs are supported, for example:
+  #
+  # catalog-1-id: custom
   # catalog-1-name: tekton
-  # catalog-1-url: https://api.other.com/v1
+  # catalog-1-url: https://api.custom.hub/v1
+  # catalog-1-type: tektonhub
+  #
+  # With this configuration, a catalog of type "tektonhub" (or alternatively,
+  # of type "artifacthub") named "custom" will be available at
+  # https://api.custom.hub/v1, using the catalog named "tekton" . Users can
+  # reference these catalogs in their templates like this:
   #
-  # this configuration will have a new catalog named anotherhub on  https://api.other.com/v1 endpoint and catalog name tekton
-  # to be used by a user in their templates like this:
-  # pipelinesascode.tekton.dev/task: "anotherhub://task"
+  # pipelinesascode.tekton.dev/task: "custom://task"
   #
-  # Increase the number of the catalog to add more of them
+  # Increase the number of the catalogs to add more of them. catalog-2-*,
+  # catalog-3-*, etc.
 
   # Allow fetching remote tasks
   remote-tasks: "true"

docs/content/_index.md

@@ -37,7 +37,7 @@ tracking using a Git workflow.
 
 - Pull-request "*GitOps*" actions through comments with  `/retest`, `/test <pipeline-name>` and so on.
 
-- Automatic Task resolution in Pipelines (local Tasks, Tekton Hub, and remote URLs)
+- Automatic Task resolution in Pipelines (local Tasks, Artifact Hub, and remote URLs)
 
 - Efficient use of GitHub blobs and objects API for retrieving configurations
 

docs/content/docs/guide/authoringprs.md

@@ -44,7 +44,7 @@ Here is a list of all the dynamic variables available in Pipelines-as-Code. The
 one that would be the most important to you would probably be the `revision` and `repo_url`
 variables, they will give you the commit SHA and the repository URL that is
 getting tested. You usually use this with the
-[git-clone](https://hub.tekton.dev/tekton/task/git-clone) task to be able to
+[git-clone](https://artifacthub.io/packages/tekton-task/tekton-catalog-tasks/git-clone) task to be able to
 check out the code that is being tested.
 
 | Variable            | Description                                                                                                                                                                     | Example                             | Example Output                                                                                                                                                |
@@ -196,12 +196,16 @@ The token value is stored in the temporary git-auth secret as generated for [pri
 repositories](../privaterepo/) in the key `git-provider-token`.
 
 As an example, if you want to add a comment to your pull request, you can use the
-[github-add-comment](https://hub.tekton.dev/tekton/task/github-add-comment)
-task from the [Tekton Hub](https://hub.tekton.dev)
-using a [pipelines as code annotation](../resolver/#remote-http-url):
+[github-add-comment](https://artifacthub.io/packages/tekton-task/tekton-catalog-tasks/github-add-comment)
+task from [Artifact Hub](https://artifacthub.io) or the same task from
+[Tekton Hub](https://hub.tekton.dev/) using a [pipelines as code annotation](../resolver/#hub-support-for-tasks):
 
 ```yaml
+# Using Artifact Hub (default)
 pipelinesascode.tekton.dev/task: "github-add-comment"
+
+# Or explicitly using Tekton Hub
+pipelinesascode.tekton.dev/task: "tektonhub://github-add-comment"
 ```
 
 you can then add the task to your [tasks section](https://tekton.dev/docs/pipelines/pipelines/#adding-tasks-to-the-pipeline) (or [finally](https://tekton.dev/docs/pipelines/pipelines/#adding-finally-to-the-pipeline) tasks) of your PipelineRun :

docs/content/docs/guide/cli.md

@@ -251,7 +251,7 @@ current Git information if you run the command from your source code.
 
 It has some basic language detection and adds extra tasks depending on the
 language. For example, if it detects a file named `setup.py` at the repository
-root it will add the [pylint task](https://hub.tekton.dev/tekton/task/pylint) to
+root it will add the [pylint task](https://artifacthub.io/packages/tekton-task/tekton-catalog-tasks/pylint) to
 the generated PipelineRun.
 {{< /details >}}
 

docs/content/docs/guide/privaterepo.md

@@ -6,7 +6,7 @@ weight: 7
 
 Pipelines-as-Code allows the use of private repositories by creating or
 updating a secret in the target namespace. This secret contains the user token
-required for the [git-clone](https://hub.tekton.dev/tekton/task/git-clone) task
+required for the [git-clone](https://artifacthub.io/packages/tekton-task/tekton-catalog-tasks/git-clone) task
 to clone private repositories.
 
 Whenever Pipelines-as-Code creates a new PipelineRun in the target namespace,

docs/content/docs/guide/resolver.md

@@ -77,16 +77,27 @@ or multiple tasks with an array :
 pipelinesascode.tekton.dev/task: "[git-clone, pylint]"
 ```
 
-### [Tekton Hub](https://hub.tekton.dev) Support for Tasks
+### Hub Support for Tasks
 
 ```yaml
 pipelinesascode.tekton.dev/task: "git-clone"
 ```
 
-The syntax above installs the
-[git-clone](https://github.com/tektoncd-catalog/git-clone/tree/main/task/git-clone) task
-from the [tekton hub](https://hub.tekton.dev) repository querying for the latest
-version with the tekton hub API.
+By default, this syntax will install the task from Artifact Hub.
+
+Examples:
+
+```yaml
+# Using Artifact Hub (default)
+pipelinesascode.tekton.dev/task: "git-clone"
+
+# Using Tekton Hub
+pipelinesascode.tekton.dev/task: "tektonhub://git-clone"
+```
+
+{{< hint danger >}}
+The public Tekton Hub service <https://hub.tekton.dev/> is scheduled to be deprecated in the future, so we recommend using Artifact Hub for task resolution.
+{{< /hint >}}
 
 You can have multiple tasks in there if you separate them by a comma `,` around
 an array syntax with bracket:
@@ -104,29 +115,26 @@ example :
   pipelinesascode.tekton.dev/task-2: "tkn"
 ```
 
-By default, `Pipelines-as-Code` will interpret the string as the `latest` task to
-grab
-from [tekton hub](https://hub.tekton.dev).
-
 If you want to have a specific version of the task, you can add a colon `:` to
-the string and a version number, like in
-this example :
+the string and a version number, like in this example:
 
 ```yaml
-pipelinesascode.tekton.dev/task: "[git-clone:0.1]" # this will install git-clone 0.1 from tekton.hub
+# Using specific version from Artifact Hub
+pipelinesascode.tekton.dev/task: "git-clone:0.9.0"
+
+# Using specific version from Tekton Hub
+pipelinesascode.tekton.dev/task: "tektonhub://git-clone:0.1"
 ```
 
-#### Custom [Tekton Hub](https://github.com/tektoncd/hub/) Support for Tasks
+#### Custom Hub Support for Tasks
 
-Additionally if the cluster administrator has [set-up](/docs/install/settings#tekton-hub-support) a custom Tekton Hub you
-are able to reference it from your template like this example:
+Additionally if the cluster administrator has [set-up](/docs/install/settings#remote-hub-catalogs) custom Hub catalogs beyond the default Artifact Hub and Tekton Hub, you are able to reference them from your template:
 
 ```yaml
-pipelinesascode.tekton.dev/task: "[anothercatalog://curl]" # this will install curl from the custom catalog configured by the cluster administrator as anothercatalog
+pipelinesascode.tekton.dev/task: "[customcatalog://curl]" # this will install curl from the custom catalog configured by the cluster administrator as customcatalog
 ```
 
-There is no fallback to the default Tekton Hub if the custom Tekton Hub does not
-have the task referenced it will fail.
+There is no fallback between different hubs. If a task is not found in the specified hub, the Pull Request will fail.
 
 There is no support for custom hub from the CLI on the `tkn pac resolve` command.
 
@@ -284,33 +292,45 @@ or from a relative path inside the repository:
 pipelinesascode.tekton.dev/pipeline: "./tasks/pipeline.yaml
 ```
 
-### [Tekton Hub](https://hub.tekton.dev) Support for Pipelines
+### Hub Support for Pipelines
 
 ```yaml
-pipelinesascode.tekton.dev/pipeline: "[buildpacks]"
+pipelinesascode.tekton.dev/pipeline: "buildpacks"
 ```
 
-The syntax above installs the
-[buildpacks](https://github.com/tektoncd/catalog/tree/main/pipeline/buildpacks) pipeline
-from the [tekton hub](https://hub.tekton.dev) repository querying for the latest
-version with the tekton hub API.
+By default, this syntax will install the pipeline from Artifact Hub.
+
+Examples:
+
+```yaml
+# Using Artifact Hub (default)
+pipelinesascode.tekton.dev/pipeline: "buildpacks"
+
+# Using Tekton Hub
+pipelinesascode.tekton.dev/pipeline: "tektonhub://buildpacks"
+```
 
 If you want to have a specific version of the pipeline, you can add a colon `:` to
-the string and a version number, like in this example :
+the string and a version number, like in this example:
 
 ```yaml
-pipelinesascode.tekton.dev/pipeline: "[buildpacks:0.1]" # this will install buildpacks 0.1 from tekton hub
+# Using specific version from Artifact Hub
+pipelinesascode.tekton.dev/pipeline: "buildpacks:0.1"
+
+# Using specific version from Tekton Hub
+pipelinesascode.tekton.dev/pipeline: "tektonhub://buildpacks:0.1"
 ```
 
-#### Custom [Tekton Hub](https://github.com/tektoncd/hub/) Support for Pipelines
+#### Custom Hub Support for Pipelines
 
-Additionally if the cluster administrator has [set-up](/docs/install/settings#tekton-hub-support) a custom Tekton Hub you
-are able to reference it from your template like this example:
+Additionally if the cluster administrator has [set-up](/docs/install/settings#remote-hub-catalogs) custom Hub catalogs beyond the default Artifact Hub and Tekton Hub, you are able to reference them from your template:
 
 ```yaml
-pipelinesascode.tekton.dev/pipeline: "[anothercatalog://buildpacks:0.1]" # this will install buildpacks from the custom catalog configured by the cluster administrator as anothercatalog
+pipelinesascode.tekton.dev/pipeline: "[customcatalog://buildpacks:0.1]" # this will install buildpacks from the custom catalog configured by the cluster administrator as customcatalog
 ```
 
+There is no fallback between different hubs. If a pipeline is not found in the specified hub, the Pull Request will fail.
+
 ### Overriding tasks from a remote pipeline on a PipelineRun
 
 {{< tech_preview "Tasks from a remote Pipeline override" >}}

docs/content/docs/install/getting-started.md

@@ -223,7 +223,7 @@ your cluster and create a directory called `.tekton` with a file named
 Note that the `tkn pac create repository` command detected that the repository
 is using the Go programming language and created a basic template for you to be
 customized tailored for the Go programming language (ie: it will add the
-[golangci-lint](https://hub.tekton.dev/tekton/task/golangci-lint) linter as a
+[golangci-lint](https://artifacthub.io/packages/tekton-task/tekton-catalog-tasks/golangci-lint) linter as a
 task to your PipelineRun).
 
 Feel free to open the file `.tekton/pipelinerun.yaml` and inspect what it

docs/content/docs/install/operator_installation.md

@@ -10,11 +10,17 @@ On the OpenShift Pipelines Operator, the default namespace is `openshift-pipelin
 
 **Note:**
 
-When Pipelines-as-Code is installed through the [Tekton Operator](https://github.com/tektoncd/operator) the configurations of Pipelines-as-Code is
+When Pipelines-as-Code is installed through the [Tekton Operator](https://github.com/tektoncd/operator) the configuration of Pipelines-as-Code is
 controlled by [TektonConfig Custom Resource](https://github.com/tektoncd/operator/blob/main/docs/TektonConfig.md#openshiftpipelinesascode).
-That means Tekton Operator will revert the configurations changes done directly on `pipeline-as-code` configmap or `OpenShiftPipelinesAsCode` custom resource.
+That means Tekton Operator will revert the configuration changes done directly
+on `pipeline-as-code` configmap or `OpenShiftPipelinesAsCode` custom resource.
 
-The default configurations for Pipelines-as-Code in `TektonConfig` looks like below
+The default configurations for Pipelines-as-Code in `TektonConfig` looks like
+below.
+Note that since version v0.37.0, Pipelines-as-Code defaults to using Artifact
+Hub rather than Tekton Hub. Tekton Hub is deprecated and will be removed in a
+future version. You can still use the public tekton hub instance  by explicitly
+prefixing your task with `tektonhub://`
 
 ```yaml
 apiVersion: operator.tekton.dev/v1alpha1
@@ -36,8 +42,8 @@ spec:
           enable-cancel-in-progress-on-pull-requests: 'false'
           enable-cancel-in-progress-on-push: 'false'
           skip-push-event-for-pr-commits: 'true'
-          hub-url: 'https://api.hub.tekton.dev/v1'
-          hub-catalog-name: tekton
+          hub-url: 'https://artifacthub.io'
+          hub-catalog-type: 'artifacthub'
           error-detection-max-number-of-lines: '50'
           error-detection-simple-regexp: >-
             ^(?P<filename>[^:]*):(?P<line>[0-9]+):(?P<column>[0-9]+):([

docs/content/docs/install/settings.md

@@ -179,31 +179,47 @@ There is a few things you can configure through the config map
 
   This is disabled by default.
 
-### Tekton Hub support
+### Remote Hub Catalogs
 
-Pipelines-as-Code supports fetching task with its remote annotations feature, by default it will fetch it from the [public tekton hub](https://hub.tekton.dev/) but you can configure it to point to your own with these settings:
+Pipelines-as-Code supports fetching tasks and pipelines with its remote annotations feature. By default, it will fetch from [Artifact Hub](https://artifacthub.io/), but you can also implicitly use the [Tekton Hub](https://hub.tekton.dev/) by using the `tektonhub://` prefix (as documented below) or point to your own custom hub with these settings:
 
 * `hub-url`
 
-  The base URL for the [tekton hub](https://github.com/tektoncd/hub/)
-  API. This default to the [public hub](https://hub.tekton.dev/): <https://api.hub.tekton.dev/v1>
+  The base URL for the hub API. For Artifact Hub (default), this is set to <https://artifacthub.io>. For Tekton Hub, it would be <https://api.hub.tekton.dev/v1>.
 
 * `hub-catalog-name`
 
-  The [tekton hub](https://github.com/tektoncd/hub/) catalog name. default to `tekton`
+  The catalog name in the hub. For Artifact Hub, the defaults are `tekton-catalog-tasks` for tasks and `tekton-catalog-pipelines` for pipelines. For Tekton Hub, this defaults to `tekton`.
 
-* Additionally you can have multiple hub configured by using the following format:
+* `hub-catalog-type`
+
+  The type of hub catalog. Supported values are:
+  
+  * `artifacthub` - For Artifact Hub (default if not specified)
+  * `tektonhub` - For Tekton Hub
+
+* By default, both Artifact Hub and Tekton Hub are configured:
+  
+  * Artifact Hub is the default catalog (no prefix needed, but `artifact://` can be used explicitly)
+  * Tekton Hub is available using the `tektonhub://` prefix
+
+* Additionally you can have multiple hubs configured by using the following format:
 
   ```yaml
   catalog-1-id: "custom"
   catalog-1-name: "tekton"
   catalog-1-url: "https://api.custom.hub/v1"
+  catalog-1-type: "tektonhub"
+  
+  catalog-2-id: "artifact"
+  catalog-2-name: "tekton-catalog-tasks"
+  catalog-2-url: "https://artifacthub.io"
+  catalog-2-type: "artifacthub"
   ```
 
-  Users are able to reference the custom hub by adding a `custom://` prefix to
-  their task they want to fetch from the `custom` catalog.
+  Users are able to reference the custom hub by adding a prefix matching the catalog ID, such as `custom://` for a task they want to fetch from the `custom` catalog.
 
-  You can add as many custom hub as you want by incrementing the `catalog-NUMBER` number.
+  You can add as many custom hubs as you want by incrementing the `catalog-NUMBER` number.
 
   Pipelines-as-Code will not try to fallback to the default or another custom hub
   if the task referenced is not found (the Pull Request will be set as failed)

hack/dev/kind/install.sh

@@ -193,11 +193,10 @@ function configure_pac() {
   sed -e "s,%DOMAIN_NAME%,${DOMAIN_NAME}," -e "s,%SERVICE_NAME%,${service_name}," ingress-pac.yaml | kubectl apply -f-
 
   kubectl patch configmap -n pipelines-as-code -p "{\"data\":{\"bitbucket-cloud-check-source-ip\": \"false\"}}" pipelines-as-code &&
-    kubectl patch configmap -n pipelines-as-code -p "{\"data\":{\"tekton-dashboard-url\": \"http://dashboard.${DOMAIN_NAME}\"}}" --type merge pipelines-as-code
-  # add custom catalog so we can use it in e2e, this will points to the normal upstream hub so we can easily use it
-  kubectl patch configmap -n pipelines-as-code -p '{"data":{"catalog-1-id": "custom", "catalog-1-name": "tekton", "catalog-1-url": "https://api.hub.tekton.dev/v1"}}' --type merge pipelines-as-code
-  # add one more custom catalog so we can use it in e2e for multiple catalog support, this will points to the normal upstream hub so we can easily use it
-  kubectl patch configmap -n pipelines-as-code -p '{"data":{"catalog-2-id": "custom2", "catalog-2-name": "tekton", "catalog-2-url": "https://api.hub.tekton.dev/v1"}}' --type merge pipelines-as-code
+    kubectl patch configmap -n pipelines-as-code -p "{\"data\":{\"tekton-dashboard-url\": \"http://dashboard.${DOMAIN_NAME}\"}}" --type merge pipelines-as-code &&
+    kubectl patch configmap -n pipelines-as-code -p \
+      '{"data":{"catalog-1-type": "artifacthub", "catalog-1-id": "pachub", "catalog-1-name": "pipelines-as-code", "catalog-1-url": "https://artifacthub.io"}}' \
+      --type merge pipelines-as-code
   set +x
   if [[ -n ${PAC_PASS_SECRET_FOLDER} ]]; then
     echo "Installing PAC secrets"