Skip to content

Conversation

zakisk
Copy link
Contributor

@zakisk zakisk commented Oct 11, 2025

This commit introduces the ability to trigger, retest, and cancel pipeline runs on GitLab tags using GitOps comments on commits.

Key features:

  • Support /test tag:<tagname>, /retest tag:<tagname>, and /cancel tag:<tagname> GitOps comments on commits
  • Validate that the commented commit matches the tag before processing the request
  • Enable retriggering pipelines on existing tagged commits without creating new tags

Testing:

  • Add comprehensive unit tests covering success and error scenarios
  • Add end-to-end test validating the complete workflow from tag creation to pipeline execution

Use cases:

  • Release management: retrigger pipelines on tagged releases
  • Troubleshooting: re-run failed pipelines on existing tags
  • Flexible CI/CD workflows for version-specific builds

📝 Description of the Change

👨🏻‍ Linked Jira

https://issues.redhat.com/browse/SRVKP-8612

🔗 Linked GitHub Issue

Fixes #

🚀 Type of Change

  • 🐛 Bug fix (fix:)
  • ✨ New feature (feat:)
  • 💥 Breaking change (feat!:, fix!:)
  • 📚 Documentation update (docs:)
  • ⚙️ Chore (chore:)
  • 💅 Refactor (refactor:)
  • 🔧 Enhancement (enhance:)
  • 📦 Dependency update (deps:)

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

  • GitHub Copilot
  • ChatGPT (OpenAI)
  • Claude (Anthropic)
  • Cursor
  • Gemini (Google)
  • Other: ____________

Extent of AI Assistance:

  • Documentation and research only
  • Unit tests or E2E tests only
  • Code generation (parts of the code)
  • Full code generation (most of the PR)
  • PR description and comments
  • Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini [email protected]
Co-authored-by: ChatGPT [email protected]
Co-authored-by: Claude [email protected]
Co-authored-by: Cursor [email protected]
Co-authored-by: Copilot [email protected]

**💡You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

Copy link

Summary of Changes

Hello @zakisk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly extends the GitOps capabilities for GitLab users by enabling pipeline control directly through comments on tagged commits. This feature provides greater flexibility for managing releases, re-running builds for specific versions, and troubleshooting issues on immutable tagged states, streamlining CI/CD workflows for version-specific operations.

Highlights

  • GitOps Command Support for GitLab Tags: Introduced the ability to use GitOps comments like /test tag:<tagname>, /retest tag:<tagname>, and /cancel tag:<tagname> to trigger, retest, or cancel pipeline runs directly on GitLab tags.
  • Commit-Tag Validation: Implemented validation to ensure that the commit on which a GitOps comment is made matches the commit ID of the specified tag, preventing unintended pipeline executions.
  • Enhanced Testing: Added comprehensive unit tests for various success and error scenarios related to tag-based GitOps commands, along with a new end-to-end test to validate the complete workflow from tag creation to pipeline execution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable feature by adding GitOps command support for GitLab tags. The implementation is well-structured and includes comprehensive unit and end-to-end tests. My review focuses on improving code clarity and test reliability. I've identified a potentially problematic removal of e2e build tags, a redundant cleanup call in a test, and an outdated code comment. Addressing these points will enhance the overall quality and maintainability of the changes.

@zakisk zakisk force-pushed the SRVKP-8612-retriggering-on-tag-gitlab branch from 8260a1f to fdede36 Compare October 11, 2025 14:33
This commit introduces the ability to trigger, retest, and cancel
pipeline runs on GitLab tags using GitOps comments on commits.

Key features:
- Support `/test tag:<tagname>`, `/retest tag:<tagname>`, and
  `/cancel tag:<tagname>` GitOps comments on commits
- Validate that the commented commit matches the tag before
  processing the request
- Enable retriggering pipelines on existing tagged commits without
  creating new tags

Testing:
- Add comprehensive unit tests covering success and error scenarios
- Add end-to-end test validating the complete workflow from tag
  creation to pipeline execution

Use cases:
- Release management: retrigger pipelines on tagged releases
- Troubleshooting: re-run failed pipelines on existing tags
- Flexible CI/CD workflows for version-specific builds

https://issues.redhat.com/browse/SRVKP-8612

Signed-off-by: Zaki Shaikh <[email protected]>
@zakisk zakisk force-pushed the SRVKP-8612-retriggering-on-tag-gitlab branch from fdede36 to 9fafa8b Compare October 11, 2025 14:37
@zakisk
Copy link
Contributor Author

zakisk commented Oct 13, 2025

/test

Copy link

🔍 PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

🤖 AI attribution

The following commits lack an explicit AI attribution footer:

  • 9fafa8b feat: Add GitOps command support for tags in GitLab

If no AI assistance was used for a commit, you can ignore this warning.
Otherwise add an Assisted-by: or Co-authored-by: footer referencing the AI used.


ℹ️ Next Steps

  • Review and address the items above
  • Push new commits to update this PR
  • This comment will be automatically updated when issues are resolved
🔧 Admin Tools (click to expand)

Automated Issue/Ticket Creation:

  • /issue-create - Generate a GitHub issue from this PR content using AI
  • /jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

🤖 This feedback was generated automatically by the PR CI system

@pipelines-as-code pipelines-as-code bot added feature New feature or request gitlab gitops labels Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request gitlab gitops

Development

Successfully merging this pull request may close these issues.

1 participant