Skip to content

Conversation

@zakisk
Copy link
Contributor

@zakisk zakisk commented Dec 9, 2025

Update Bitbucket Cloud provider to use GetCheckName helper for commit status key. This enables unique status reporting per PipelineRun by using the format "ApplicationName / PipelineRunName" instead of just the application name.

Changes:

  • Replace hardcoded ApplicationName with GetCheckName in CreateStatus
  • Update tests to include OriginalPipelineRunName in StatusOpts
  • Add assertion in MuxCreateCommitstatus to verify correct key format

Fixes: #2337

📝 Description of the Change

👨🏻‍ Linked Jira

https://issues.redhat.com/browse/SRVKP-9636

🚀 Type of Change

  • 🐛 Bug fix (fix:)
  • ✨ New feature (feat:)
  • 💥 Breaking change (feat!:, fix!:)
  • 📚 Documentation update (docs:)
  • ⚙️ Chore (chore:)
  • 💅 Refactor (refactor:)
  • 🔧 Enhancement (enhance:)
  • 📦 Dependency update (deps:)

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

If you have used AI assistance, please provide the following details:

Which LLM was used?

  • GitHub Copilot
  • ChatGPT (OpenAI)
  • Claude (Anthropic)
  • Cursor
  • Gemini (Google)
  • Other: ____________

Extent of AI Assistance:

  • Documentation and research only
  • Unit tests or E2E tests only
  • Code generation (parts of the code)
  • Full code generation (most of the PR)
  • PR description and comments
  • Commit message(s)

Important

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Gemini [email protected]
Co-authored-by: ChatGPT [email protected]
Co-authored-by: Claude [email protected]
Co-authored-by: Cursor [email protected]
Co-authored-by: Copilot [email protected]

**💡You can use the script ./hack/add-llm-coauthor.sh to automatically add
these co-author trailers to your commits.

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

@gemini-code-assist
Copy link

Summary of Changes

Hello @zakisk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue in the Bitbucket Cloud integration where commit statuses were not uniquely identified per PipelineRun. By implementing a dynamic key generation mechanism, the system can now report distinct statuses for individual PipelineRuns, improving clarity and preventing conflicts in the Bitbucket UI.

Highlights

  • Unique Commit Status Keys: The Bitbucket Cloud provider now assigns unique commit status keys for each PipelineRun. Previously, it used a generic application name, which could lead to status overwrites or confusion when multiple PipelineRuns were active.
  • Dynamic Key Generation: The GetCheckName helper function is now utilized to generate the commit status key, incorporating both the application name and the specific PipelineRun name (e.g., 'ApplicationName / PipelineRunName').
  • Enhanced Test Coverage: Unit tests for CreateStatus have been updated to include the OriginalPipelineRunName in StatusOpts, ensuring that the new unique key generation logic is correctly tested and verified. An assertion has also been added to confirm the correct key format in mock API calls.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@pipelines-as-code
Copy link

pipelines-as-code bot commented Dec 9, 2025

🔍 PR Lint Feedback

Note: This automated check helps ensure your PR follows our contribution guidelines.

⚠️ Items that need attention:

🤖 AI attribution

The following commits lack an explicit AI attribution footer:

  • d1a3a5d fix(bitbucket-cloud): assign unique statue name in Bitbucket Cloud

If no AI assistance was used for a commit, you can ignore this warning.
Otherwise add an Assisted-by: or Co-authored-by: footer referencing the AI used.


ℹ️ Next Steps

  • Review and address the items above
  • Push new commits to update this PR
  • This comment will be automatically updated when issues are resolved
🔧 Admin Tools (click to expand)

Automated Issue/Ticket Creation:

  • /issue-create - Generate a GitHub issue from this PR content using AI
  • /jira-create - Create a SRVKP Jira ticket from this PR content using AI

⚠️ Important: Always review and edit generated content before finalizing tickets/issues.
The AI-generated content should be used as a starting point and may need adjustments.

These commands are available to maintainers and will post the generated content as PR comments for review.

🤖 This feedback was generated automatically by the PR CI system

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with non-unique commit status names in Bitbucket Cloud by incorporating the PipelineRun name into the status key. The change correctly utilizes the provider.GetCheckName helper function for this purpose. The implementation is sound, and the accompanying test updates are appropriate. I've included one suggestion to enhance the test coverage by parameterizing it for custom application names, which would increase the robustness of the test suite. Overall, this is a solid fix.

Update Bitbucket Cloud provider to use GetCheckName helper for commit
status key. This enables unique status reporting per PipelineRun by
using the format "ApplicationName / PipelineRunName" instead of just
the application name.

Changes:
- Replace hardcoded ApplicationName with GetCheckName in CreateStatus
- Update tests to include OriginalPipelineRunName in StatusOpts
- Add assertion in MuxCreateCommitstatus to verify correct key format

Fixes: openshift-pipelines#2237

JIRA: https://issues.redhat.com/browse/SRVKP-9636

Signed-off-by: Zaki Shaikh <[email protected]>
@zakisk zakisk force-pushed the SRVKP-9636-report-status-per-pipelinerun branch from 4f216be to d1a3a5d Compare December 9, 2025 05:53
@zakisk
Copy link
Contributor Author

zakisk commented Dec 9, 2025

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request centralizes the generation of the Bitbucket Cloud commit status key by introducing a new provider.GetCheckName function. Previously, the key was directly derived from v.pacInfo.ApplicationName. The change in pkg/provider/bitbucketcloud/bitbucket.go updates the CreateStatus function to use this new helper. Correspondingly, the test suite in pkg/provider/bitbucketcloud/bitbucket_test.go and pkg/provider/bitbucketcloud/test/bbcloudtest.go has been updated to reflect and verify this change. This includes adding OriginalPipelineRunName to test status options, introducing a new test case for applicationName, dynamically setting the application name in tests, and modifying the MuxCreateCommitstatus helper to accept and assert against the applicationName when validating the generated commit status key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

bitbucketcloud: push events - multiple (parallel) pipelines not showing up distinctly in git

1 participant