Automator: merge upstream changes to openshift-service-mesh/istio@master#646
Merged
openshift-merge-bot[bot] merged 6 commits intoopenshift-service-mesh:masterfrom Mar 9, 2026
Conversation
* test: replace time.Sleep with retry loops in jwks_resolver_test Replace two time.Sleep calls in jwks_resolver_test.go with proper event-driven retry loops to reduce unnecessary wait times: 1. verifyKeyLastRefreshedTime: replaced time.Sleep(200ms) with retry.UntilSuccessOrFail polling loop (5ms interval) that exits as soon as the refresh timestamp changes (or doesn't). 2. TestJwtPubKeyRefreshedWhenErrorsGettingOtherURLs: replaced time.Sleep(2*refreshInterval) with retry.UntilOrFail polling loop that exits as soon as the expected JwtPubKey2 is returned. These tests were listed in istio/istio#37555 as taking 1.25s and 1.06s respectively due to the fixed sleeps. With retry-based polling, they will complete as soon as the condition is met rather than always waiting the full sleep duration. Resolves part of: istio/istio#37555 * test: fix review comments - remove dead code and fix false-positive in wantChanged=false - Remove dead code after retry.UntilOrFail in TestJwtPubKeyRefreshedWhenErrorsGettingOtherURLs (err==nil and pk==JwtPubKey2 are already guaranteed by a successful retry loop) - Fix false-positive in verifyKeyLastRefreshedTime when wantChanged=false: wait for at least one refresh cycle (via refreshJobKeyChangedCount / refreshJobFetchFailedCount) before asserting the timestamp did not change --------- Co-authored-by: Nagendra Reddy <nagendrareddy10@users.noreply.github.com>
This is useful for tests which dump the index output
* fix: make wasm OCI image binary size limit configurable via env var * Move ISTIO_WASM_OCI_MAX_BINARY_SIZE_BYTES env var to pilot/pkg/features * add release note for wasm OCI image binary size limit configuration * Apply configurable wasm binary size limit to extractOCIArtifactImage as well * use int64 to match io.LimitReader signature * Apply pilot feature to httpfetcher wasm binary size limit
* upstream/master: Automator: update proxy@master in istio/istio@master (#59336) Automator: update go-control-plane in istio/istio@master (#59354) Allow configuring wasm binary size limit via pilot env var (#59335) krt: allow listing index collection (#59342) test: replace time.Sleep with retry loops in jwks_resolver_test (#59246)
Contributor
|
/retest |
openshift-merge-bot
bot
merged commit 03d195c
into
openshift-service-mesh:master
14 checks passed
|
@openshift-service-mesh-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by Automator - 2026-03-09T05:07:15+00:00