ossm: add script for uploading built ztunnel to gs #14
Conversation
Signed-off-by: Zuzana Miklankova <[email protected]>
| fi | ||
|
|
||
| tar czf ./out/rust/release/ztunnel.tar.gz ./out/rust/release/ztunnel | ||
| gsutil cp bazel-bin/envoy_tar.tar.gz "${ARTIFACTS_GCS_PATH}/ztunnel-alpha-${SHA}${ARCH_SUFFIX}.tar.gz" |
There was a problem hiding this comment.
- we should copy ztunnel, not envoy binary
- are you sure we need to rename it to ztunnel-alpha? I'd check at https://github.com/istio/istio/blob/master/bin/build_ztunnel.sh#L127-L133
Take a look at those Istio scripts to see if it's really necessary to upload a binary artifact, or if Istio is capable of building ztunnel from source. Proxy is done that way because building proxy is really an expensive task.
There was a problem hiding this comment.
we should copy ztunnel, not envoy binary
oh, good catch!
Take a look at those Istio scripts to see if it's really necessary to upload a binary artifact, or if Istio is capable of building ztunnel from source. Proxy is done that way because building proxy is really an expensive task.
Good point, will do that.
Thanks.
No need to perform any prior creation. If a directory doesn't exist, it's created on demand. |
2 participants
This should be similar to https://github.com/openshift-service-mesh/proxy/blob/release-1.27/ossm/ci/post-submit.sh and should have the same purpose.
I have not done any steps to create
gs://maistra-prow-testing/ztunnelyet.