API review: remove BpfApplicationState GetClientObject

andreaskaris · andreaskaris · commit 1588c9c85348 · 2025-10-09T17:50:31.000+02:00
Method GetClientObject is not used and removing it removes
the dependency on sigs.k8s.io/controller-runtime/pkg/client

Signed-off-by: Andreas Karis &lt;ak.karis@gmail.com&gt;
diff --git a/bpfman-operator/apis/v1alpha1/bpf_application_state_types.go b/bpfman-operator/apis/v1alpha1/bpf_application_state_types.go
@@ -19,7 +19,6 @@ package v1alpha1
 import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	metav1types "k8s.io/apimachinery/pkg/types"
-	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
 // +union
@@ -181,10 +180,6 @@ func (an BpfApplicationState) GetConditions() []metav1.Condition {
 	return an.Status.Conditions
 }
 
-func (an BpfApplicationState) GetClientObject() client.Object {
-	return &an
-}
-
 func (anl BpfApplicationStateList) GetItems() []BpfApplicationState {
 	return anl.Items
 }

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ package v1alpha1`
`19`	`19`	`import (`
`20`	`20`	`metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"`
`21`	`21`	`metav1types "k8s.io/apimachinery/pkg/types"`
`22`		`- "sigs.k8s.io/controller-runtime/pkg/client"`
`23`	`22`	`)`
`24`	`23`
`25`	`24`	`// +union`
`@@ -181,10 +180,6 @@ func (an BpfApplicationState) GetConditions() []metav1.Condition {`
`181`	`180`	`return an.Status.Conditions`
`182`	`181`	`}`
`183`	`182`
`184`		`-func (an BpfApplicationState) GetClientObject() client.Object {`
`185`		`- return &an`
`186`		`-}`
`187`		`-`
`188`	`183`	`func (anl BpfApplicationStateList) GetItems() []BpfApplicationState {`
`189`	`184`	`return anl.Items`
`190`	`185`	`}`