Skip to content

Conversation

barbacbd
Copy link
Contributor

operatoringress/v1/types.go:

** Add the new DNS Record Type for "AAAA" which is an RFC 3596 record used to map a domain name to an IPv6 address.

Intention/Function Examples:

** Cluster Ingress operator will use this new record type when a DNS record for IPv6 addresses is to be created. ** Openshift Installer will use this new record type when a DNS record for IPv6 addresses is to be created.

operatoringress/v1/types.go:

** Add the new DNS Record Type for "AAAA" which is an RFC 3596 record used to map a domain name to an IPv6 address.

Intention/Function Examples:

** Cluster Ingress operator will use this new record type when a DNS record for IPv6 addresses is to be created.
** Openshift Installer will use this new record type when a DNS record for IPv6 addresses is to be created.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025

@barbacbd: This pull request references CORS-4096 which is a valid jira issue.

In response to this:

operatoringress/v1/types.go:

** Add the new DNS Record Type for "AAAA" which is an RFC 3596 record used to map a domain name to an IPv6 address.

Intention/Function Examples:

** Cluster Ingress operator will use this new record type when a DNS record for IPv6 addresses is to be created. ** Openshift Installer will use this new record type when a DNS record for IPv6 addresses is to be created.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

Hello @barbacbd! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 10, 2025
@openshift-ci openshift-ci bot requested review from everettraven and JoelSpeed June 10, 2025 13:32
@JoelSpeed
Copy link
Contributor

/approve

@Miciah any concerns about this from a CIO side?

Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@barbacbd
Copy link
Contributor Author

/cc @Miciah

@openshift-ci openshift-ci bot requested a review from Miciah June 10, 2025 14:15
Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

@barbacbd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/hold

We should probably have this addition behind a feature gate, is there an appropriate feature that would own this?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2025
@sadasu
Copy link
Contributor

sadasu commented Aug 11, 2025

/hold

We should probably have this addition behind a feature gate, is there an appropriate feature that would own this?

#2430 contains the feature gates. Running make update is resulting in changes that are unrelated to the PR, requiring manual intervention after the scripts are run. I'll be posting an update soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants