Skip to content

AGENT-1262: set NoRegistryClusterOperations as techPreviewNoUpgrade #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

AGENT-1262: set NoRegistryClusterOperations as techPreviewNoUpgrade #2432

merged 1 commit into from
Aug 26, 2025

Conversation

andfasano
Copy link
Contributor

@andfasano andfasano commented Aug 1, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 1, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2025 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-1262 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 1, 2025

Hello @andfasano! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2025 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-1262 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

cc @zaneb @pamoedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Contributor

/approve

/assign @zaneb @pamoedom

LGTM if you're happy with this moving to TP

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2025
@pamoedom
Copy link

pamoedom commented Aug 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2025
@andfasano andfasano force-pushed the update-noregistryclusterops-feature branch from f115b1e to 535e4c8 Compare August 1, 2025 10:02
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2025
@pamoedom
Copy link

pamoedom commented Aug 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c7fbd08 and 2 for PR HEAD 535e4c8 in total

@andfasano
Copy link
Contributor Author

/retest

@pawanpinjarkar
Copy link

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 32616f0 and 2 for PR HEAD 535e4c8 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 32616f0 and 2 for PR HEAD 535e4c8 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 32616f0 and 2 for PR HEAD 535e4c8 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9f36190 and 1 for PR HEAD 535e4c8 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9f36190 and 2 for PR HEAD 535e4c8 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9f36190 and 2 for PR HEAD 535e4c8 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2025
@andfasano andfasano force-pushed the update-noregistryclusterops-feature branch from 535e4c8 to 3ed7395 Compare August 21, 2025 10:24
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 21, 2025
@pamoedom
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, JoelSpeed, pamoedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 58dfa6d and 2 for PR HEAD 3ed7395 in total

@andfasano
Copy link
Contributor Author

/test e2e-gcp

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3d5bf11 and 1 for PR HEAD 3ed7395 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3d5bf11 and 2 for PR HEAD 3ed7395 in total

3 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3d5bf11 and 2 for PR HEAD 3ed7395 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3d5bf11 and 2 for PR HEAD 3ed7395 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3d5bf11 and 2 for PR HEAD 3ed7395 in total

@andfasano
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 25, 2025 •
edited
Loading

@andfasano: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 3ed7395 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andfasano
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 25, 2025 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-1262 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link

/retest-required

@andfasano
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Aug 26, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 4a165b2 into openshift:master Aug 26, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven Awaiting requested review from everettraven

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@zaneb zaneb

@pamoedom pamoedom

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@andfasano @openshift-ci-robot @JoelSpeed @pamoedom @pawanpinjarkar @zaneb @openshift-merge-robot