Skip to content

Conversation

isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Aug 11, 2025

This recreates #2383 with an added commit to resolve the PR's merge conflicts.

Work included

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 11, 2025

@isabella-janssen: This pull request references MCO-1675 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This recreates #2383 with an added commit to resolve the PR's merge conflicts.

Work included

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2025
Copy link
Contributor

openshift-ci bot commented Aug 11, 2025

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 11, 2025
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Aug 12, 2025

/retitle MCO-1675: Update API for Status Reporting needs (REBASED)
/lgtm

@openshift-ci openshift-ci bot changed the title (WIP) MCO-1675: Update API for Status Reporting needs (REBASED) MCO-1675: Update API for Status Reporting needs (REBASED) Aug 12, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 12, 2025

@isabella-janssen: This pull request references MCO-1675 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This recreates #2383 with an added commit to resolve the PR's merge conflicts.

Work included

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 213cdac and 2 for PR HEAD daaca27 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8187a76 and 2 for PR HEAD daaca27 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 88b2b21 and 1 for PR HEAD daaca27 in total

@JoelSpeed
Copy link
Contributor

/override ci/prow/verify-crd-schema

False positives, new required field has a new optional parent

/test e2e-aws-serial-techpreview-2of2

Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

False positives, new required field has a new optional parent

/test e2e-aws-serial-techpreview-2of2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yuqi-zhang
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 88b2b21 and 2 for PR HEAD daaca27 in total

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4bbb180 and 2 for PR HEAD daaca27 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4bbb180 and 2 for PR HEAD daaca27 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3413131 and 1 for PR HEAD daaca27 in total

@JoelSpeed
Copy link
Contributor

/override ci/prow/verify-crd-schema

False positive

Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

False positive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6282350 and 0 for PR HEAD daaca27 in total

@openshift-ci-robot
Copy link

/hold

Revision daaca27 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@isabella-janssen
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6282350 and 2 for PR HEAD daaca27 in total

@isabella-janssen
Copy link
Member Author

/test e2e-aws-serial-techpreview-2of2

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06d1bd7 and 1 for PR HEAD daaca27 in total

@everettraven
Copy link
Contributor

Overriding the verify-crd-schema check because the new required field is a child of a new optional field.

/override ci/prow/verify-crd-schema

Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-crd-schema

In response to this:

Overriding the verify-crd-schema check because the new required field is a child of a new optional field.

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06d1bd7 and 2 for PR HEAD daaca27 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2d04128 and 1 for PR HEAD daaca27 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2d04128 and 2 for PR HEAD daaca27 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 58dfa6d and 1 for PR HEAD daaca27 in total

@everettraven
Copy link
Contributor

/override ci/prow/verify-crd-schema

Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3d5bf11 and 0 for PR HEAD daaca27 in total

@openshift-ci-robot
Copy link

/hold

Revision daaca27 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2025
@isabella-janssen
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3d5bf11 and 2 for PR HEAD daaca27 in total

@isabella-janssen
Copy link
Member Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Aug 25, 2025

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure daaca27 link false /test e2e-azure
ci/prow/okd-scos-e2e-aws-ovn daaca27 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-serial-techpreview-2of2 daaca27 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-ovn-techpreview daaca27 link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants