CORS-4184: Add STS IAMCredentials and OAuth Service for GCP Endpoint Overrides #2444
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@barbacbd: This pull request references CORS-4184 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @barbacbd! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/L
|
Do these changes require any further implementation, or is it, once in the API, we are good to go? |
|
/test e2e-aws-ovn |
The installer will require the api import update. Other than that they should be good to go. The CCO is the use case here, but that will grab the infrastructure config. |
|
/retest-required |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
barbacbd
changed the title
|
/lgtm |
openshift-ci
bot
added
lgtm
2 similar comments
|
/retest-required |
2 similar comments
…Overrides ** These services were a bit unconventional. The STS and IAMCredential services are not called directly in CCO but through a WIF template. The OAuth Service is also a bit unconventional, as it is never called directly but will still require a GCP endpoint override to ensure that the traffic does not go to the default google endpoint.
openshift-ci
bot
added
size/XXL
openshift-ci
bot
added
size/L
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barbacbd, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 3413131
into
openshift:master
** These services were a bit unconventional. The STS service is not called directly in CCO but through a WIF template. The OAuth Service is also a bit unconventional, as it is never called directly but will still require a GCP endpoint override to ensure that the traffic does not go to the default google endpoint.