Skip to content

Conversation

everettraven
Copy link
Contributor

@everettraven everettraven commented Aug 18, 2025

to include everettraven and remove deads2k.

I've been shadowing @JoelSpeed as an API reviewer for ~8 months now and have actively been contributing to reviews and API-related tooling to improve the API review process.

As per a conversation with Joel, I'm adding myself as an approver and removing David Eads as a reviewer

Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

Hello @everettraven! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2025
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed August 18, 2025 17:16
to include everettraven as approver and remove deads2k as reviewer.

Signed-off-by: Bryce Palmer <[email protected]>
@everettraven everettraven force-pushed the owners/add-approver-everettraven branch from 00fcae3 to 40f346f Compare August 18, 2025 17:55
@JoelSpeed
Copy link
Contributor

/lgtm

Thank you @everettraven for all of your hard work on API review through 2025

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

@everettraven: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4bbb180 into openshift:master Aug 19, 2025
13 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202508192316.p0.g4bbb180.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants