Fix missing metrics-proxy-daemonset.yaml in OpenShift Containerfile #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing COPY instruction for metrics-proxy-daemonset.yaml to the OpenShift-specific Containerfile. This resolves operator panics that occur when the bpfman-operator attempts to load the metrics proxy daemonset configuration file at runtime but cannot find it in the container filesystem. The metrics proxy functionality was added in commit 63cde58 but the OpenShift Containerfile was not updated to include the necessary file copy instruction, whilst the regular Containerfile was properly updated. This ensures parity between the two build processes and prevents runtime failures when deploying the operator via OperatorHub on OpenShift clusters.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test all |
|
@frobware: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BPFman operator panics on OpenShift when deployed via OperatorHub. The controller crashes trying to load
./config/bpfman-deployment/metrics-proxy-daemonset.yamlwhich doesn't exist in the container.Cause
When metrics proxy support was added in 63cde58, the regular Containerfile was updated to copy the new config file but the OpenShift-specific Containerfile was missed. This means:
Fix
Add the missing COPY line to the OpenShift Containerfile to match what's already in the regular one.