-
Notifications
You must be signed in to change notification settings - Fork 36
Update OCP documentation links to latest versions #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update OCP documentation links to latest versions #327
Conversation
This commit updates OpenShift Container Platform documentation URLs to point to the latest available versions. Updated by: ocp-doc-checker More info: https://github.com/sebrandon1/ocp-doc-checker
WalkthroughTwo documentation links in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebrandon1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
docs/operand_metrics.md
Outdated
| ### Enable User Workload Monitoring | ||
|
|
||
| Cluster administrators can enable monitoring for user-defined projects by setting the `enableUserWorkload: true` field in the cluster monitoring ConfigMap object. For more details, Please look at the detailed documentation to [Configuring user workload monitoring](https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/monitoring/configuring-user-workload-monitoring). | ||
| Cluster administrators can enable monitoring for user-defined projects by setting the `enableUserWorkload: true` field in the cluster monitoring ConfigMap object. For more details, Please look at the detailed documentation to [Configuring user workload monitoring](https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/monitoring/configuring-user-workload-monitoring). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Cluster administrators can enable monitoring for user-defined projects by setting the `enableUserWorkload: true` field in the cluster monitoring ConfigMap object. For more details, Please look at the detailed documentation to [Configuring user workload monitoring](https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/monitoring/configuring-user-workload-monitoring). | |
| Cluster administrators can enable monitoring for user-defined projects by setting the `enableUserWorkload: true` field in the cluster monitoring ConfigMap object. For more details, Please look at the detailed documentation to [Configuring user workload monitoring](https://docs.redhat.com/en/documentation/openshift_container_platform/latest/html/monitoring/configuring-user-workload-monitoring). |
docs/operand_metrics.md
Outdated
| ### Query Metrics | ||
|
|
||
| As a cluster administrator or as a user with view permissions for all projects, You can access these metrics using the command line or via the OpenShift web console. For more details, Please look at the detailed documentation to [Accessing metrics](https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/monitoring/accessing-metrics). | ||
| As a cluster administrator or as a user with view permissions for all projects, You can access these metrics using the command line or via the OpenShift web console. For more details, Please look at the detailed documentation to [Accessing metrics](https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/monitoring/accessing-metrics). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| As a cluster administrator or as a user with view permissions for all projects, You can access these metrics using the command line or via the OpenShift web console. For more details, Please look at the detailed documentation to [Accessing metrics](https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/monitoring/accessing-metrics). | |
| As a cluster administrator or as a user with view permissions for all projects, You can access these metrics using the command line or via the OpenShift web console. For more details, Please look at the detailed documentation to [Accessing metrics](https://docs.redhat.com/en/documentation/openshift_container_platform/latest/html/monitoring/accessing-metrics). |
|
@bharath-b-rh Would you rather them be |
I feel so, since cert-manager releases aren't directly mapped to OCP releases. The latest always gets translated to the current release, and we wouldn't need to update it after every OCP release. |
This commit updates OpenShift Container Platform documentation URLs to point to the latest available versions. Updated by: ocp-doc-checker More info: https://github.com/sebrandon1/ocp-doc-checker
|
Updated with latest OCP documentation links (ran ocp-doc-checker again). All documentation URLs now point to the latest available versions. |
|
@sebrandon1: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebrandon1 first off thanks for your PR!
I assume we don't really need to worry about a version is not "latest" in this markdown doc. The equivalent content for customers reference is already there at https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/security_and_compliance/cert-manager-operator-for-red-hat-openshift#cert-manager-monitoring
My major concern is sometimes the RH docs paths would change between major releases. That means https://docs.redhat.com/.../<a future version>/html/monitoring/configuring-user-workload-monitoring might not always work. But what we could confirm is that 4.18 is not broken and won't be broken in the future.
I'd lean towards we keep it as-is to avoid bumping it every release and verifying if it's still valid. WDYT?
This PR updates OpenShift Container Platform documentation URLs to point to the latest available versions.
Changes
Tool Information
This PR was created automatically by scanning the repository with
ocp-doc-checker, which identifies and updates outdated OpenShift documentation links.Repository: https://github.com/sebrandon1/ocp-doc-checker
Tracking Issue: sebrandon1/ocp-doc-checker#18