-
Notifications
You must be signed in to change notification settings - Fork 62
CNTRLPLANE-1110: Issue HCPServiceHealthCheckDisruption
for 4.18 -> 4.19.[0-4]
#7619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNTRLPLANE-1110: Issue HCPServiceHealthCheckDisruption
for 4.18 -> 4.19.[0-4]
#7619
Conversation
@petr-muller: This pull request references CNTRLPLANE-1110 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
292597d
to
33975f9
Compare
Should we also bump the minimum 4.20 upgrade version too? https://github.com/openshift/cincinnati-graph-data/blob/master/build-suggestions/4.20.yaml#L2 |
…4.19.[0-4] Set up a known issue for HyperShift hosted clusters on AWS. PromQL was taken and adapted from earlier `HCPMetallbCNOCannotDeployFRRK8S` and `AWSCustomDomainNodesNotReady` I do not have a suitable HCP cluster at hand but I tested the PromQL structurally on a standalone AWS cluster: ``` ( group by (_id, invoker) (cluster_installer{_id="",invoker="user"}) or 0 * group by (_id, invoker) (cluster_installer{_id=""}) ) and on (_id) ( group by (type) (cluster_infrastructure_provider{_id="",type="AWS"}) ) or on (_id) ( 0 * group by (type) (cluster_infrastructure_provider{_id=""}) ) ```
33975f9
to
18f68bc
Compare
8b65f51
to
e3d5d07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Getting back to this, I'm not clear if this specific issue needs a 4.19.floor -> 4.20 bump. But there will be additional issues like openshift/cluster-version-operator#1193 merging later in 4.19.z that will definitely need a 4.19.floor bump, so I don't think we need to worry about bottoming out whether this issue needs one. |
@petr-muller: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Set up a known issue for HyperShift hosted clusters on AWS. PromQL was taken and adapted from earlier
HCPMetallbCNOCannotDeployFRRK8S
andAWSCustomDomainNodesNotReady
I do not have a suitable HCP cluster at hand but I tested the PromQL structurally on a standalone AWS cluster: