Skip to content

Conversation

petr-muller
Copy link
Member

Set up a known issue for HyperShift hosted clusters on AWS. PromQL was taken and adapted from earlier HCPMetallbCNOCannotDeployFRRK8S and AWSCustomDomainNodesNotReady

I do not have a suitable HCP cluster at hand but I tested the PromQL structurally on a standalone AWS cluster:

(
  group by (_id, invoker) (cluster_installer{_id="",invoker="user"})
  or
  0 * group by (_id, invoker) (cluster_installer{_id=""})
)
and on (_id) (
  group by (type) (cluster_infrastructure_provider{_id="",type="AWS"})
)
or on (_id) (
  0 * group by (type) (cluster_infrastructure_provider{_id=""})
)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2025

@petr-muller: This pull request references CNTRLPLANE-1110 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Set up a known issue for HyperShift hosted clusters on AWS. PromQL was taken and adapted from earlier HCPMetallbCNOCannotDeployFRRK8S and AWSCustomDomainNodesNotReady

I do not have a suitable HCP cluster at hand but I tested the PromQL structurally on a standalone AWS cluster:

(
 group by (_id, invoker) (cluster_installer{_id="",invoker="user"})
 or
 0 * group by (_id, invoker) (cluster_installer{_id=""})
)
and on (_id) (
 group by (type) (cluster_infrastructure_provider{_id="",type="AWS"})
)
or on (_id) (
 0 * group by (type) (cluster_infrastructure_provider{_id=""})
)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from DavidHurta and hongkailiu July 17, 2025 14:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2025
@petr-muller petr-muller force-pushed the 4.19-HCPServiceHealthCheckDisruption branch from 292597d to 33975f9 Compare July 17, 2025 14:40
@sdodson
Copy link
Member

sdodson commented Jul 17, 2025

Should we also bump the minimum 4.20 upgrade version too? https://github.com/openshift/cincinnati-graph-data/blob/master/build-suggestions/4.20.yaml#L2

…4.19.[0-4]

Set up a known issue for HyperShift hosted clusters on AWS. PromQL was taken and adapted from earlier `HCPMetallbCNOCannotDeployFRRK8S` and `AWSCustomDomainNodesNotReady`

I do not have a suitable HCP cluster at hand but I tested the PromQL structurally on a standalone AWS cluster:

```
(
  group by (_id, invoker) (cluster_installer{_id="",invoker="user"})
  or
  0 * group by (_id, invoker) (cluster_installer{_id=""})
)
and on (_id) (
  group by (type) (cluster_infrastructure_provider{_id="",type="AWS"})
)
or on (_id) (
  0 * group by (type) (cluster_infrastructure_provider{_id=""})
)
```
@petr-muller petr-muller force-pushed the 4.19-HCPServiceHealthCheckDisruption branch from 33975f9 to 18f68bc Compare July 17, 2025 15:16
@petr-muller petr-muller force-pushed the 4.19-HCPServiceHealthCheckDisruption branch from 8b65f51 to e3d5d07 Compare July 22, 2025 12:55
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2025
Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Jul 22, 2025

Should we also bump the minimum 4.20 upgrade version too?

Getting back to this, I'm not clear if this specific issue needs a 4.19.floor -> 4.20 bump. But there will be additional issues like openshift/cluster-version-operator#1193 merging later in 4.19.z that will definitely need a 4.19.floor bump, so I don't think we need to worry about bottoming out whether this issue needs one.

Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 46bcc3e into openshift:master Jul 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants