-
Notifications
You must be signed in to change notification settings - Fork 159
CCO-805: Ability to use featureGates #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Previously, the leader election was not being released when there was an error starting the operator. This caused a delay when the operator was restarted while it waited for the leader election timeout. This significantly delayed the bootstrap process if the static pod experienced an error, sometimes causing it to fail altogether. This change adds better error handling to the operator startup processes in order to ensure it releases leader election when experiencing an error. Assisted-by: gemini-3-pro-preview
This change adds the ability to get the featureGates from the cluster. This can be built upon by new features to ensure their functionality is protected by the desired featureGate until ready for GA.
|
@jstuever: This pull request references CCO-805 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
==========================================
- Coverage 46.48% 46.31% -0.17%
==========================================
Files 98 98
Lines 12181 12225 +44
==========================================
Hits 5662 5662
- Misses 5869 5913 +44
Partials 650 650
🚀 New features to boost your workflow:
|
|
/override ci/prow/security |
|
/assign @dlom |
|
@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jstuever: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This change adds the ability to get the featureGates from the cluster.
This can be built upon by new features to ensure their functionality is
protected by the desired featureGate until ready for GA.
This change also adds better error handling to the operator startup
processes in order to ensure it releases leader election when experiencing
an error.
Assisted-by: gemini-3-pro-preview